Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deployment event note #4283

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Fix deployment event note #4283

merged 4 commits into from
Nov 8, 2024

Conversation

qwerty287
Copy link
Contributor

closes #4275

@qwerty287 qwerty287 added the documentation docu & docs label Nov 2, 2024
@qwerty287 qwerty287 requested a review from a team November 2, 2024 07:59
@woodpecker-bot
Copy link
Contributor

woodpecker-bot commented Nov 2, 2024

Deployment of preview was torn down

Copy link
Contributor

@pat-s pat-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a stab at this.

I think the whole deployment topic needs to be distinguished in more detail:

  • the only forge which issues a deployment event is AFAIK GH
  • deployments can be triggered from within WP itself

I agree on removing this the highlighted part here but I think all pages referencing it (including the forge matrix listing the part about "deployment") need a footnote or some other way of explaining the difference between the forge event and the WP event in detail. Otherwise such questions will continue to pop up.

@qwerty287
Copy link
Contributor Author

@pat-s Can you checkout 9cc397623? It adds some footnotes.

@qwerty287 qwerty287 requested a review from pat-s November 8, 2024 12:16
Copy link
Contributor

@pat-s pat-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, definitely better than before 👍 Let's see if more issues related to this come up in the future.

@pat-s pat-s enabled auto-merge (squash) November 8, 2024 12:28
@pat-s pat-s merged commit ac1962b into woodpecker-ci:main Nov 8, 2024
7 checks passed
@woodpecker-bot woodpecker-bot mentioned this pull request Nov 8, 2024
1 task
@woodpecker-bot woodpecker-bot mentioned this pull request Dec 14, 2024
1 task
@qwerty287 qwerty287 deleted the deploy-docs branch January 26, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation docu & docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants