-
-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deployment event note #4283
Conversation
Deployment of preview was torn down |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a stab at this.
I think the whole deployment topic needs to be distinguished in more detail:
- the only forge which issues a
deployment
event is AFAIK GH deployment
s can be triggered from within WP itself
I agree on removing this the highlighted part here but I think all pages referencing it (including the forge matrix listing the part about "deployment") need a footnote or some other way of explaining the difference between the forge event and the WP event in detail. Otherwise such questions will continue to pop up.
@pat-s Can you checkout 9cc397623? It adds some footnotes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, definitely better than before 👍 Let's see if more issues related to this come up in the future.
closes #4275