Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server configuration option to add default set of labels for workflows that has no labels specified #4326

Merged
merged 6 commits into from
Nov 14, 2024

Conversation

lafriks
Copy link
Contributor

@lafriks lafriks commented Nov 6, 2024

Fixes #4324
Probably fixes #2634

Have not tested yet but wanted to open to get initial feedback

@lafriks lafriks added server enhancement improve existing features build_pr_images If set, the CI will build images for this PR and push to Dockerhub labels Nov 6, 2024
@lafriks lafriks added this to the 3.0.0 milestone Nov 6, 2024
@woodpecker-bot
Copy link
Contributor

woodpecker-bot commented Nov 6, 2024

Deployment of preview was torn down

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 16.00000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 27.37%. Comparing base (f4d7e9f) to head (3be2ff4).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
server/pipeline/items.go 0.00% 11 Missing ⚠️
cmd/server/setup.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4326      +/-   ##
==========================================
- Coverage   27.37%   27.37%   -0.01%     
==========================================
  Files         380      380              
  Lines       27781    27794      +13     
==========================================
+ Hits         7606     7608       +2     
- Misses      19490    19501      +11     
  Partials      685      685              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lafriks lafriks marked this pull request as ready for review November 14, 2024 20:10
@lafriks lafriks requested a review from 6543 November 14, 2024 20:10
@lafriks
Copy link
Contributor Author

lafriks commented Nov 14, 2024

I'm already running this in our production (cherry-picked on v2.7.1) and currently all seems to work as expected so I think it's ready to review

@6543 6543 enabled auto-merge (squash) November 14, 2024 21:15
@6543 6543 merged commit 5699d22 into woodpecker-ci:main Nov 14, 2024
7 checks passed
@6543 6543 deleted the feat/default_filter branch November 14, 2024 22:56
@woodpecker-bot woodpecker-bot mentioned this pull request Nov 14, 2024
1 task
@lafriks lafriks removed the build_pr_images If set, the CI will build images for this PR and push to Dockerhub label Nov 15, 2024
@woodpecker-bot woodpecker-bot mentioned this pull request Dec 14, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing features server
Projects
None yet
3 participants