Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup openapi generation #4331

Merged
merged 44 commits into from
Nov 23, 2024
Merged

Cleanup openapi generation #4331

merged 44 commits into from
Nov 23, 2024

Conversation

anbraten
Copy link
Member

@anbraten anbraten commented Nov 6, 2024 •
edited
Loading

  • rename swagger to openapi (as we convert to openapi v3 afterwards & swagger is openapi v2)
  • run swag fmt to format openapi annotations of routes
  • fix agent_id param was named agent
  • fix version was using object & string => only string
  • use tools.go and go run to install correct version of swag

@anbraten anbraten added the bug Something isn't working label Nov 6, 2024
@anbraten anbraten added this to the 3.0.0 milestone Nov 6, 2024
@anbraten anbraten marked this pull request as ready for review November 6, 2024 18:50
@woodpecker-bot
Copy link
Contributor

woodpecker-bot commented Nov 6, 2024 •
edited
Loading

Deployment of preview was torn down

qwerty287
qwerty287 reviewed Nov 8, 2024
View reviewed changes
cmd/server/tools.go Outdated Show resolved Hide resolved
6543
6543 reviewed Nov 13, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
6543
6543 previously approved these changes Nov 18, 2024
View reviewed changes
@qwerty287
Copy link
Contributor

Is that ready? Why was the approval dismissed?

@anbraten
Copy link
Member Author

I had the dismiss on new commits option active unintentinally while changing settings and thereby it was dismissed. Code should be ready though.

qwerty287
qwerty287 approved these changes Nov 23, 2024
View reviewed changes
Copy link
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untested

@anbraten anbraten enabled auto-merge (squash) November 23, 2024 07:58
@anbraten anbraten merged commit 07c8765 into woodpecker-ci:main Nov 23, 2024
6 of 8 checks passed
@woodpecker-bot woodpecker-bot mentioned this pull request Nov 23, 2024
Merged
1 task
@woodpecker-bot woodpecker-bot mentioned this pull request Dec 14, 2024
Merged
1 task
@BrewTestBot BrewTestBot mentioned this pull request Jan 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwerty287 qwerty287 qwerty287 approved these changes

@6543 6543 6543 left review comments

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anbraten @woodpecker-bot @qwerty287 @6543