Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass settings to services #4338

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Conversation

qwerty287
Copy link
Contributor

to achieve #4336

@qwerty287 qwerty287 added the enhancement improve existing features label Nov 8, 2024
@qwerty287 qwerty287 added this to the 3.0.0 milestone Nov 8, 2024
@qwerty287 qwerty287 requested a review from a team November 8, 2024 12:25
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 26.55%. Comparing base (bf5405b) to head (00ff7fc).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
pipeline/frontend/yaml/compiler/convert.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4338      +/-   ##
==========================================
- Coverage   26.55%   26.55%   -0.01%     
==========================================
  Files         379      379              
  Lines       27548    27546       -2     
==========================================
- Hits         7316     7315       -1     
+ Misses      19563    19562       -1     
  Partials      669      669              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@6543 6543 merged commit e13085b into woodpecker-ci:main Nov 9, 2024
8 of 9 checks passed
@woodpecker-bot
Copy link
Contributor

@woodpecker-bot woodpecker-bot mentioned this pull request Nov 9, 2024
1 task
@qwerty287 qwerty287 deleted the service-settings branch November 10, 2024 05:59
@6543 6543 mentioned this pull request Nov 11, 2024
@6543 6543 added server engine change how the pipeline engine works and removed server labels Nov 11, 2024
@woodpecker-bot woodpecker-bot mentioned this pull request Dec 14, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine change how the pipeline engine works enhancement improve existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants