Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move api-routes to separate file #434

Merged
merged 4 commits into from
Oct 12, 2021
Merged

Move api-routes to separate file #434

merged 4 commits into from
Oct 12, 2021

Conversation

anbraten
Copy link
Member

No description provided.

@anbraten anbraten added the refactor delete or replace old code label Oct 12, 2021
@anbraten anbraten added this to the 0.15.0 milestone Oct 12, 2021
6543
6543 reviewed Oct 12, 2021
View reviewed changes
server/router/apiRouter.go Outdated Show resolved Hide resolved
6543
6543 reviewed Oct 12, 2021
View reviewed changes
server/router/apiRouter.go Outdated Show resolved Hide resolved
@anbraten anbraten requested a review from 6543 October 12, 2021 18:41
jolheiser
jolheiser approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@jolheiser jolheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would maybe just call the file api.go since router/apiRouter stutters as a filename, but that's just being pedantic. 😉

lgtm

@anbraten
Copy link
Member Author

anbraten commented Oct 12, 2021 •
edited
Loading

I would maybe just call the file api.go since router/apiRouter stutters as a filename, but that's just being pedantic. wink

lgtm

That's a think golangci-lint suggests as well, right? Or was it just for packages names and variables inside that package with the name included again? Maybe we should add it?

@jolheiser
Copy link
Member

That's a think golangci-lint suggests as well, right? Maybe we should add it?

I'm not sure if it checks filenames, but it does check package/struct names.
Either way, I agree with adding it. It has some good linters (and some bad ones) which can be useful.

@anbraten anbraten mentioned this pull request Oct 12, 2021
Closed
@anbraten anbraten enabled auto-merge (squash) October 12, 2021 18:58
@anbraten anbraten merged commit e6183e3 into woodpecker-ci:master Oct 12, 2021
@anbraten anbraten mentioned this pull request Oct 12, 2021
Merged
58 tasks
@anbraten anbraten deleted the move-api-routes branch December 1, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jolheiser jolheiser jolheiser approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
refactor delete or replace old code
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anbraten @jolheiser @6543