Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use KeyValueEditor for DeployPipelinePopup too #4412

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Use KeyValueEditor for DeployPipelinePopup too #4412

merged 2 commits into from
Nov 19, 2024

Conversation

6543
Copy link
Member

@6543 6543 commented Nov 19, 2024

Just make use of what was introduced in #4153

@6543 6543 added ui frontend related refactor delete or replace old code labels Nov 19, 2024
@6543 6543 requested a review from qwerty287 November 19, 2024 13:05
qwerty287
qwerty287 approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested. Is it still possible to add empty env vars?

@6543
Copy link
Member Author

6543 commented Nov 19, 2024

It works like the old, it just adds visual validation :)

@6543 6543 merged commit ce8cd02 into woodpecker-ci:main Nov 19, 2024
6 of 7 checks passed
@6543 6543 deleted the refactor-ui-deploy-popup branch November 19, 2024 15:08
@woodpecker-bot
Copy link
Contributor

Tearing down https://woodpecker-ci-woodpecker-pr-4412.surge.sh

@woodpecker-bot woodpecker-bot mentioned this pull request Nov 19, 2024
Merged
1 task
@6543 6543 mentioned this pull request Nov 20, 2024
Draft
@woodpecker-bot woodpecker-bot mentioned this pull request Dec 14, 2024
Merged
1 task
@BrewTestBot BrewTestBot mentioned this pull request Jan 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwerty287 qwerty287 qwerty287 approved these changes

Assignees
No one assigned
Labels
refactor delete or replace old code ui frontend related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@6543 @woodpecker-bot @qwerty287