Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination options to all supported endpoints in sdk #4463

Merged
merged 5 commits into from
Nov 27, 2024
Merged

Conversation

xoxys
Copy link
Member

@xoxys xoxys commented Nov 26, 2024

Follow-up: #3652

@xoxys xoxys marked this pull request as draft November 26, 2024 11:00
@6543 6543 added lib about our woodpecker-go api lib breaking will break existing installations if no manual action happens labels Nov 26, 2024
@6543 6543 added this to the 3.0.0 milestone Nov 26, 2024
@6543 6543 added the enhancement improve existing features label Nov 26, 2024
@woodpecker-bot
Copy link
Contributor

woodpecker-bot commented Nov 26, 2024

Deployment of preview was torn down

@xoxys xoxys marked this pull request as ready for review November 26, 2024 19:21
@xoxys xoxys requested a review from a team November 26, 2024 19:21
@pat-s pat-s requested a review from qwerty287 November 26, 2024 20:06
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 2.64901% with 147 lines in your changes missing coverage. Please review.

Project coverage is 28.19%. Comparing base (b23c724) to head (0bcfdd5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pipeline/rpc/proto/woodpecker.pb.go 0.00% 84 Missing ⚠️
pipeline/rpc/proto/woodpecker_grpc.pb.go 0.00% 16 Missing ⚠️
woodpecker-go/woodpecker/repo.go 0.00% 12 Missing ⚠️
woodpecker-go/woodpecker/org.go 0.00% 8 Missing ⚠️
cli/secret/secret_list.go 0.00% 5 Missing ⚠️
woodpecker-go/woodpecker/global_registry.go 0.00% 4 Missing ⚠️
woodpecker-go/woodpecker/global_secret.go 0.00% 4 Missing ⚠️
cli/admin/registry/registry_list.go 0.00% 3 Missing ⚠️
cli/org/registry/registry_list.go 0.00% 3 Missing ⚠️
cli/repo/registry/registry_list.go 0.00% 3 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4463      +/-   ##
==========================================
+ Coverage   27.97%   28.19%   +0.22%     
==========================================
  Files         384      384              
  Lines       28052    27833     -219     
==========================================
  Hits         7847     7847              
+ Misses      19516    19297     -219     
  Partials      689      689              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xoxys xoxys merged commit 08bd52a into main Nov 27, 2024
9 checks passed
@xoxys xoxys deleted the wp-go-opts-2 branch November 27, 2024 06:53
@woodpecker-bot woodpecker-bot mentioned this pull request Nov 27, 2024
1 task
@woodpecker-bot woodpecker-bot mentioned this pull request Dec 14, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking will break existing installations if no manual action happens enhancement improve existing features lib about our woodpecker-go api lib
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants