-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce exact matching for GitLab groups #4473
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
approved these changes
Nov 28, 2024
Deployment of preview was torn down |
that should be backported, wana do it or should I cherry pick? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4473 +/- ##
==========================================
+ Coverage 28.20% 28.22% +0.01%
==========================================
Files 385 385
Lines 27847 27852 +5
==========================================
+ Hits 7855 7860 +5
Misses 19301 19301
Partials 691 691 ☔ View full report in Codecov by Sentry. |
Backport: #4474 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-done
indicates that this pull has been backported
bug
Something isn't working
forge/gitlab
gitlab forge related
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2922
Until now, GL groups were matched partially. This caused an issue in the following case:
By enforcing an exact match, the query returns
nil
for a non-existing top-level group and will attempt to (correctly) create a new WP org for it, letting the overall repo add operation succeed.Fix has already been tested to work.
I don't think there should be any potential downsides when switching to exact matching.
Besides, I also updated the error message wording I encountered.
Should be backported.