Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify cli commands and flags #4481

Merged
merged 5 commits into from
Nov 30, 2024
Merged

Unify cli commands and flags #4481

merged 5 commits into from
Nov 30, 2024

Conversation

xoxys
Copy link
Member

@xoxys xoxys commented Nov 29, 2024 •
edited
Loading

  • Unify command and flag descriptions
  • Unify logs
  • Rename woodpecker-cli [registry|ssecret|...] info commands to woodpecker-cli [registry|ssecret|...] show

@xoxys xoxys added enhancement improve existing features breaking will break existing installations if no manual action happens cli labels Nov 29, 2024
@xoxys xoxys requested a review from a team November 29, 2024 23:48
@woodpecker-bot
Copy link
Contributor

woodpecker-bot commented Nov 29, 2024 •
edited
Loading

Deployment of preview was torn down

qwerty287
qwerty287 reviewed Nov 30, 2024
View reviewed changes
Copy link
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think server and agent mostly use lowercase messages for the logs.

cli/internal/util.go Outdated Show resolved Hide resolved
cmd/cli/main.go Outdated Show resolved Hide resolved
@xoxys
Copy link
Member Author

xoxys commented Nov 30, 2024

Ok then Ill adjust it in the cli. Just switched to the most used variant in cli.

@xoxys xoxys requested a review from a team November 30, 2024 10:44
@qwerty287 qwerty287 mentioned this pull request Nov 30, 2024
Merged
@6543 6543 enabled auto-merge (squash) November 30, 2024 14:16
@6543 6543 merged commit 57e7572 into main Nov 30, 2024
6 of 7 checks passed
@6543 6543 deleted the cleanup-cli branch November 30, 2024 14:23
@woodpecker-bot woodpecker-bot mentioned this pull request Nov 30, 2024
Merged
1 task
@woodpecker-bot woodpecker-bot mentioned this pull request Dec 14, 2024
Merged
1 task
@BrewTestBot BrewTestBot mentioned this pull request Jan 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwerty287 qwerty287 qwerty287 approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
breaking will break existing installations if no manual action happens cli enhancement improve existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xoxys @woodpecker-bot @6543 @qwerty287