Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop native Let's Encrypt support #4541

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Conversation

qwerty287
Copy link
Contributor

closes #1680

@qwerty287 qwerty287 added server refactor delete or replace old code breaking will break existing installations if no manual action happens labels Dec 9, 2024
@qwerty287 qwerty287 added this to the 3.0.0 milestone Dec 9, 2024
@woodpecker-bot
Copy link
Contributor

woodpecker-bot commented Dec 9, 2024

Deployment of preview was torn down

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 28.29%. Comparing base (786a8fb) to head (dae8a6d).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
cmd/server/server.go 0.00% 2 Missing ⚠️
cmd/server/health.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4541      +/-   ##
==========================================
+ Coverage   28.26%   28.29%   +0.02%     
==========================================
  Files         399      399              
  Lines       28179    28156      -23     
==========================================
  Hits         7966     7966              
+ Misses      19507    19484      -23     
  Partials      706      706              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pat-s pat-s merged commit 355ebcd into woodpecker-ci:main Dec 9, 2024
8 of 9 checks passed
@woodpecker-bot woodpecker-bot mentioned this pull request Dec 9, 2024
1 task
@qwerty287 qwerty287 deleted the drop-le branch December 9, 2024 18:05
@woodpecker-bot woodpecker-bot mentioned this pull request Dec 14, 2024
1 task
pat-s pushed a commit that referenced this pull request Dec 18, 2024
pat-s pushed a commit that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking will break existing installations if no manual action happens refactor delete or replace old code server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WOODPECKER_LETS_ENCRYPT support is crashing the server
3 participants