Fix BB ambiguous commit status key #4544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bitbucket commit status depends on the status key (key=id). A status with the same key overwrites the previous status, even when the triggering event is different (e.g. pull_request or branch). Set the key depending on the pipeline context.
anbraten
added
bug
anbraten
approved these changes
Dec 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4544 +/- ##
=======================================
Coverage 28.26% 28.26%
=======================================
Files 399 399
Lines 28179 28179
=======================================
Hits 7966 7966
Misses 19507 19507
Partials 706 706 ☔ View full report in Codecov by Sentry. |
|
Tearing down https://woodpecker-ci-woodpecker-pr-4544.surge.sh |
j04n-f
added a commit
to j04n-f/woodpecker
that referenced
this pull request
Dec 10, 2024
Co-authored-by: Joan Flotats <joanflotats@bit2me.com>
pat-s
pushed a commit
that referenced
this pull request
Dec 18, 2024
Co-authored-by: Joan Flotats <joanflotats@bit2me.com>
pat-s
pushed a commit
that referenced
this pull request
Dec 18, 2024
Co-authored-by: Joan Flotats <joanflotats@bit2me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bitbucket commit status depends on the status key (key=id). A status with the same key overwrites the previous status, even when the triggering event is different (e.g., pull_request or branch).
Problem
When
pull_requestandpushevents are enabled, the commit status is overwritten by the last workflow to finish (only when there's a PR open). This happens because both workflow keys are equal.Solution
Set the key depending on the pipeline context, like the BB data center. Users can use BB settings to block their PRs depending on the workflow name.