Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add linter support for step-level depends_on existence #4657

Merged
merged 5 commits into from
Jan 12, 2025

Conversation

stevapple
Copy link
Contributor

RT. This is useful as one could typo or forget to update the name everywhere.

Note that this PR is not implementing #1139, which is otherwise at workflow level.

@qwerty287 qwerty287 added the enhancement improve existing features label Jan 3, 2025
Copy link
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

pipeline/frontend/yaml/linter/linter.go Outdated Show resolved Hide resolved
@qwerty287 qwerty287 changed the title feat(cli): add linter support for step-level depends_on existence feat: add linter support for step-level depends_on existence Jan 3, 2025
Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 28.22%. Comparing base (628c0e8) to head (c288701).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
pipeline/frontend/yaml/linter/linter.go 89.47% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4657      +/-   ##
==========================================
+ Coverage   28.18%   28.22%   +0.04%     
==========================================
  Files         398      398              
  Lines       28245    28265      +20     
==========================================
+ Hits         7960     7978      +18     
- Misses      19575    19576       +1     
- Partials      710      711       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qwerty287 qwerty287 merged commit 5e75e4e into woodpecker-ci:main Jan 12, 2025
9 checks passed
@woodpecker-bot
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants