Tag pipeline with source information #4796
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indirectly adds labels to Kubernetes pods for use with NetworkPolicies and other integrations.
Co-authored-by: qwerty287 <80460567+qwerty287@users.noreply.github.com>
Add pipeline labels to Kubernetes Pods
|
@xoxys can you maybe take a look at this seconds attempt? It have been tested, linted, and confirmed running with the correct labels applied to Kubernetes pods |
xoxys
reviewed
Feb 5, 2025
| delete(item.Labels, key) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Those labels should not be mixed with the existing labels as those are used for filtering etc. Can we not add a new struct field e.g. item.InternalLabels or item.MetadataLabels here already?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the seconds attempt trying to get this to work.
Indirectly adds labels to Kubernetes pods for use with NetworkPolicies and other integrations.
TODO:
woodpecker/server/grpc/filter.go
Line 32 in 00aa968