Change paths to use woodpecker instead of drone #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anbraten
commented
Oct 28, 2021
jolheiser
approved these changes
Oct 28, 2021
|
I think as the base path change changes the path of the sqlite file as well it is fine that we keep both changes in one PR. If you want, feel free to update your PR to get credits 😉 |
This was referenced Oct 28, 2021
6543
added
breaking
6543
reviewed
Oct 29, 2021
| if c.String("datasource") == "/var/lib/woodpecker/woodpecker.sqlite" { | ||
| _, err := os.Stat("/var/lib/drone/drone.sqlite") | ||
| if err == nil { | ||
| return os.Rename("/var/lib/drone/drone.sqlite", "/var/lib/woodpecker/woodpecker.sqlite") |
There was a problem hiding this comment.
this is not the best sol. since if you mout volume at /var/lib/drone it will move the DB outside of the volume!!
There was a problem hiding this comment.
Instead of renaming I would propose to detect on driver=sqlite3 where the file could be on following order:
- /var/lib/woodpecker/woodpecker.sqlite -> All fine
- /var/lib/woodpecker/drone.sqlite -> rename to /var/lib/woodpecker/woodpecker.sqlite (print a warining(renamed ...))
- /var/lib/drone/drone.sqlite -> do nothing just use it and print a error!
6543
added a commit
that referenced
this pull request
Oct 30, 2021
#494 introduced a bug, where a migration function can remove the sqlite3 file outside of the mounted docker volume. that would result in a data lose after a container recreate. this fix it by only rename the file if in same folder else just use the old path as fallback and put warnings into the log Co-authored-by: Anbraten <anton@ju60.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major part of this PR has been implemented by @jolheiser in #438 and #431