Use Woodpecker theme colors on Safari Tab Bar / Header Bar #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ci failed related: https://ci.woodpecker-ci.org/woodpecker-ci/woodpecker/build/1536/28 |
Add theme-color <meta> tag and dynamically change the theme-color when switching into / out of dark mode.
ktprograms
force-pushed
the
fix-safari_tab_bar-color
branch
from
54bf0bc to
cb9c028
Compare
anbraten
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add theme-color tag and dynamically change the theme-color when
switching into / out of dark mode.
I used the same colors as in the Navbar component, but I don't think it's possible to access the Windi CSS color definitions, so I had to hard core the hex values.
The theme-color tag needs to be present in the HTML, otherwise
querySelectorreturns null.