Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run pipeline for binary files on pull if go code changed #722

Merged
merged 8 commits into from
Jan 29, 2022
Merged

Run pipeline for binary files on pull if go code changed #722

merged 8 commits into from
Jan 29, 2022

Conversation

6543
Copy link
Member

@6543 6543 commented Jan 29, 2022 •
edited
Loading

will resolve a todo on #684

@6543 6543 added the build CI pipeline related label Jan 29, 2022
@6543 6543 added this to the 0.15.0 milestone Jan 29, 2022
@6543 6543 requested a review from a team January 29, 2022 03:53
anbraten
anbraten reviewed Jan 29, 2022
View reviewed changes
Copy link
Member

@anbraten anbraten left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of when.path.include we should be able to use when.path directly. #86 will be super helpful for such configs at some point. 😂

.woodpecker/binaries.yml Show resolved Hide resolved
.woodpecker/binaries.yml Show resolved Hide resolved
.woodpecker/binaries.yml Show resolved Hide resolved
.woodpecker/binaries.yml Show resolved Hide resolved
@6543 @anbraten
Apply suggestions from code review
77abf8c 
Co-authored-by: Anbraten <anton@ju60.de>
anbraten
anbraten reviewed Jan 29, 2022
View reviewed changes
.woodpecker/binaries.yml Outdated Show resolved Hide resolved
@6543 6543 requested a review from anbraten January 29, 2022 12:44
@6543
Copy link
Member Author

6543 commented Jan 29, 2022

PS: remove include: result in jsonschema report an error - I think we have to fix that ... but it's another pull to do s

@6543 6543 merged commit 062579d into woodpecker-ci:master Jan 29, 2022
@6543 6543 deleted the pipeline-config branch January 29, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anbraten anbraten anbraten approved these changes

Assignees
No one assigned
Labels
build CI pipeline related skip-changelog
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@6543 @anbraten