Add support for release event (Github, Gitea, Gitlab) #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LamaAni
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
LamaAni
changed the title
Codecov Report
@@ Coverage Diff @@
## master #764 +/- ##
==========================================
+ Coverage 51.58% 52.24% +0.66%
==========================================
Files 79 79
Lines 6074 6203 +129
==========================================
+ Hits 3133 3241 +108
- Misses 2760 2776 +16
- Partials 181 186 +5
Continue to review full report at Codecov.
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: 6543 <6543@obermui.de>
6543
reviewed
Mar 3, 2022
Co-authored-by: 6543 <6543@obermui.de>
6543
reviewed
Mar 3, 2022
qwerty287
reviewed
May 17, 2022
6543
reviewed
May 17, 2022
| @@ -523,13 +524,17 @@ func (g *Gitlab) Hook(ctx context.Context, req *http.Request) (*model.Repo, *mod | |||
| return nil, nil, err | |||
| } | |||
|
|
|||
| parsed, err := gitlab.ParseWebhook(gitlab.WebhookEventType(req), payload) | |||
| gitlabEventType := gitlab.WebhookEventType(req) | |||
| println("Received event: " + gitlabEventType) | |||
6543
reviewed
May 17, 2022
| @@ -267,13 +268,19 @@ func setupGitlab(c *cli.Context) (remote.Remote, error) { | |||
|
|
|||
| // helper function to setup the GitHub remote from the CLI arguments. | |||
| func setupGithub(c *cli.Context) (remote.Remote, error) { | |||
| releaseActions := regexp. | |||
| MustCompile(`[\s,]+`). | |||
| Split(c.String("github-release-actions"), -1) | |||
|
Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-764.surge.sh |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
We should apply #917 here too if there's no branch associated, but actually releases can have branches that should be parsed here. |
anbraten
changed the title
anbraten
reviewed
Sep 27, 2022
Comment on lines
+274
to
+279
| &cli.StringFlag{ | ||
| EnvVars: []string{"WOODPECKER_GITHUB_RELEASE_ACTIONS"}, | ||
| Name: "github-release-actions", | ||
| Usage: "On which actions to trigger a release pipeline", | ||
| Value: "prereleased, released", | ||
| }, |
There was a problem hiding this comment.
Instead of limiting here I would suggest to inject an environment variable to each step CI_RELEASE_TYPE=draft,pre-release,release
There was a problem hiding this comment.
And adding some filter to the when options would be good too.
There was a problem hiding this comment.
I guess this could be pretty simple by introducing #312
7 tasks
Merged
|
-> #3226 |
pat-s
added a commit
that referenced
this pull request
Jan 30, 2024
fernandrone
pushed a commit
to quintoandar/woodpecker
that referenced
this pull request
Feb 1, 2024
Supersedes woodpecker-ci#764 Bitbucket does not support release webhooks. --------- Co-authored-by: Patrick Schratz <patrick.schratz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a github developer (both public and Enterprise) I would like to be able to catch and run CI on the release event, allowing to add artifacts for release via the github GUI.
Reasons:
Changes: