Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Netrc machine from clone url (#800) #803

Merged
merged 1 commit into from
Feb 26, 2022

Conversation

6543
Copy link
Member

@6543 6543 commented Feb 26, 2022

Backport #800

We previously got the machine hostname for Netrc from the url of the remote, but in cases where the clone-url does not match the api url this can lead to errors.

We previously got the machine hostname for Netrc from the url of the remote, but in cases where the clone-url does not match the api url this can lead to errors.
@6543 6543 added bug Something isn't working server labels Feb 26, 2022
@6543 6543 added this to the 0.15.1 milestone Feb 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2022

Codecov Report

Merging #803 (6b5a187) into release/v0.15 (7a4c6d3) will decrease coverage by 0.42%.
The diff coverage is 35.71%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release/v0.15     #803      +/-   ##
=================================================
- Coverage          52.14%   51.71%   -0.43%     
=================================================
  Files                 86       88       +2     
  Lines               5953     5996      +43     
=================================================
- Hits                3104     3101       -3     
- Misses              2676     2717      +41     
- Partials             173      178       +5     
Impacted Files Coverage Δ
server/remote/bitbucketserver/bitbucketserver.go 0.00% <0.00%> (ø)
server/remote/gitlab/gitlab.go 27.36% <0.00%> (+0.34%) ⬆️
server/remote/common/utils.go 38.46% <38.46%> (ø)
server/remote/gitea/gitea.go 38.33% <40.00%> (-0.38%) ⬇️
server/remote/github/github.go 16.29% <40.00%> (-2.00%) ⬇️
server/remote/coding/coding.go 65.38% <50.00%> (-0.96%) ⬇️
server/remote/gogs/gogs.go 60.91% <50.00%> (-1.07%) ⬇️
server/remote/common/status.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a4c6d3...6b5a187. Read the comment docs.

@6543 6543 requested a review from anbraten February 26, 2022 05:44
@6543 6543 merged commit ce07632 into woodpecker-ci:release/v0.15 Feb 26, 2022
@6543 6543 deleted the backport_800 branch February 26, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants