Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape html / xml in log view #879

Merged
merged 2 commits into from
Apr 13, 2022
Merged

Escape html / xml in log view #879

merged 2 commits into from
Apr 13, 2022

Conversation

anbraten
Copy link
Member

@anbraten anbraten commented Apr 13, 2022

This fixes a security issue reported by one of our community members which allowed to print HTML and therefore JS code to the build logs which allowed code execution on the browsers reading those logs.

@6543 6543 added bug Something isn't working server labels Apr 13, 2022
@6543 6543 merged commit 3064975 into woodpecker-ci:master Apr 13, 2022
@6543 6543 added the backport-done indicates that this pull has been backported label Apr 13, 2022
@6543 6543 added this to the 1.0.0 milestone Apr 13, 2022
@anbraten anbraten deleted the fix-js branch April 13, 2022 20:42
@6543
Copy link
Member

6543 commented Apr 13, 2022

-> #880

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done indicates that this pull has been backported bug Something isn't working security server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants