Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update project to Gradle 6.9 #45

Merged
merged 5 commits into from
Feb 28, 2022
Merged

Update project to Gradle 6.9 #45

merged 5 commits into from
Feb 28, 2022

Conversation

Azurelol
Copy link
Contributor

@Azurelol Azurelol commented Feb 17, 2022 •
edited by Larusso
Loading

Description

Upgrades project to Gradle 6.9, removing some plugins that are no longer compatible.

Changes

  • UPDATE GRADLE to version 6.9
  • REMOVE Nebula release plugin

@Azurelol Azurelol changed the base branch from master to release/2.x February 21, 2022 11:34
@Azurelol Azurelol marked this pull request as ready for review February 25, 2022 11:54
Larusso
Larusso requested changes Feb 25, 2022
View reviewed changes
Copy link
Member

@Larusso Larusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok looks good in general.
I was wondering if it wouldn't be better for testing if we still support the candidate task invocation somehow. Otherwise we would need to adjust the pipeline as well. We had code in the past in the release plugin to deal with this.

build.gradle Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
gradle/wrapper/gradle-wrapper.properties Outdated Show resolved Hide resolved
src/integrationTest/groovy/wooga/gradle/node/NodeReleasePluginPublishSpec.groovy Outdated Show resolved Hide resolved
@Azurelol Azurelol force-pushed the update/gradle_6_9 branch 2 times, most recently from c798e72 to ef8cd82 Compare February 28, 2022 09:36
@ghost ghost added gradle update labels Feb 28, 2022
Larusso
Larusso reviewed Feb 28, 2022
View reviewed changes
Copy link
Member

@Larusso Larusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one depenency declaration and we are done for this part.

@Azurelol Azurelol merged commit 95ea312 into release/2.x Feb 28, 2022
@Azurelol Azurelol deleted the update/gradle_6_9 branch February 28, 2022 14:17
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Larusso Larusso Larusso approved these changes

Assignees
No one assigned
Labels
atlas-stream gradle remove update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Azurelol @Larusso