Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds includeTests opt-in for paket #89

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Azurelol
Copy link
Contributor

Description

Adds an includeTests property for our Unity packages (in addition to the existing includeAssemblies), so that projects can opt into including test source files through paket.

Overhauls how the paket.unity3d.references are parsed:

  • Backwards compatible with existing declarations
  • Provides the configuration of properties per reference (rather than just at task level)

Changes

  • IMPROVE PaketUnityPlugin
  • IMPROVE PaketUnityInstall
  • UPDATE PaketUnityReferences

Copy link
Member

@Larusso Larusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is includeAssemblies new in this PR as well? And how does it play with the

paketUnity {
    includeAssemblyDefinitions = true
}
``` extension property? Could we rename the property to `includeAssemblyDefinitions` here as well?

@Azurelol
Copy link
Contributor Author

is includeAssemblies new in this PR as well? And how does it play with the

paketUnity {
    includeAssemblyDefinitions = true
}
``` extension property? Could we rename the property to `includeAssemblyDefinitions` here as well?

Oh no, it's not.

I had some issues during the rebase. It should be correct now.

@Azurelol
Copy link
Contributor Author

I think it should be good now.

Probably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants