Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes paket bootstrap executable from PaketBootstrap task outputs #99

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

Joaquimmnetto
Copy link
Contributor

@Joaquimmnetto Joaquimmnetto commented Sep 13, 2023

Description

Fixes a bug detected in UBS, where gradle deletes the paket.bootstrap.exe file generated by the DownloadPaketBootstraper.

You can reproduce the issue by calling:

gradlew paketBootstrap #this should run correctly
rm -r .paket
gradlew paketBootstrap #this should fail, accusing that the `paket.bootstrap.exe` file doesn't exists.
# After this, subsequent calls to `paketBootstrap` works as it should, until you delete the `.paket` folder again. 

Several tests pointed out that the file is correctly downloaded, but just disappears between the DownloadPaketBootstraper and PaketBootstrap tasks. This happens because its set as an output of PaketBootstrap. Then in some conditions, gradle wipes out the file, likely to make room to some intended output, making the PaketBoostrap task fail. Removing the bootstrap executable from the outputs of PaketBootstrap solves the issue, and does not generate any side effects.

Changes

  • FIX paket.bootstrap.exe file missing when .paket folder is removed.

@Joaquimmnetto Joaquimmnetto merged commit 037f2cf into master Sep 13, 2023
1 check passed
@Azurelol
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants