Fix missing targetCommitish for github publish [ATLAS-579] #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Larusso
changed the title
Larusso
force-pushed
the
fix/missing_target_commitish_for_github_release_3.x
branch
from
1280810
to
6ef9568
Compare
Description =========== The github publish did not set the target commitish. This is important since we let github create the tag. Without this property github will generate the tag based on the main/default branch which may yield incorrect information. Changes ======= * ![FIX] missing `targetCommitish` property for github publish
Larusso
force-pushed
the
fix/missing_target_commitish_for_github_release_3.x
branch
from
6ef9568
to
867d631
Compare
|
SonarQube Quality Gate
|
Larusso
deleted the
fix/missing_target_commitish_for_github_release_3.x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The github publish did not set the target commitish. This is important since we let github create the tag. Without this property github will generate the tag based on the main/default branch which may yield incorrect information.
resolves #89
Changes
targetCommitishproperty for github publish