Fix return type of filter

[jpasquers]

Fixes #3

[wooorm]

Can you look at the tests?

[jpasquers]

Can you look at the tests?

Yep I'm looking into it. Sorry been in on and off meetings but will have some time in a bit

[wooorm]

all the time in the world, no rush, and let me know if you have Qs!

[jpasquers]

So this led me down quite the rabbit hole. As far as I could tell the ts typing was failing even in main. There is some really tricky behavior surrounding the filter option dictating the return type of the inner match method. I reached a solution which is reasonable but probably overly complicated. An additional consequence of the new type declarations is the unintended export of things like FilterOrLookup and FilterOrLookupResponse

[jpasquers]

We can go forward with this, but I definitely understand if you would rather just reformat the code or have any other insights. I just wanted to avoid touching the real code if possible.

[jpasquers]

any update here?

[wooorm]

Thanks for your patience!

As far as I could tell the ts typing was failing even in main

I see it, weird how that started happening 🤷‍♂️

An additional consequence of the new type declarations is the unintended export of things like FilterOrLookup and FilterOrLookupResponse

This can be “solved” by moving everything to lib/, and explicitly choosing which types and identifiers to export from index.js.

I just wanted to avoid touching the real code if possible.

👍

---

I’ll merge this, and will take a look at the code-style and what to export locally!

[wooorm]

Managed to remove a bunch of types that weren’t needed, and was able to get rid of the prettier-ignore: 6d4a74b?w=1

[wooorm]

Thanks, released in 2.0.2!