Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add T-T as a crying emoticon #10

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Add T-T as a crying emoticon #10

merged 2 commits into from
Aug 5, 2024

Conversation

Dlurak
Copy link
Contributor

@Dlurak Dlurak commented Aug 4, 2024

No description provided.

@wooorm
Copy link
Owner

wooorm commented Aug 4, 2024

Heya! Cool that you want to help!

Files here are generated. See https://github.com/wooorm/emoticon/blob/main/script/build-data.js for some info on how that happens.
That means your changes will be ignored. Changes have to go into the source files, too!

@Dlurak
Copy link
Contributor Author

Dlurak commented Aug 4, 2024

Oh I didn't notice that index.js is generated. As T-T is totally different from the Eyes + Nose + Mouth approach I think it's necessary that there can be totally different faces for one category.
Something like this:

{
  "cry": [
    ["eyesNormal", "drop", "noseOptional", "mouthNotPositive"],
    [["T"], ["-"], ["T"]]
  ]
}

Is this fine for you?

@wooorm
Copy link
Owner

wooorm commented Aug 4, 2024

Good point!
If you can make that work, 👍👍

@wooorm wooorm merged commit aca8be0 into wooorm:main Aug 5, 2024
2 checks passed
@wooorm
Copy link
Owner

wooorm commented Aug 5, 2024

Thanks, releasead in 4.1.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants