Make project compile on Linux #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated CMake files to support build on Linux - Deleted original Linux makefiles as they are not needed since CMake is introduced - Fixed minor problems in the code which prevented the project from compiling It likely breaks the Windows build, but hopefully it only causes minor problems those are easy to fix in a way that allows the project to compile on both platforms. The Linux CMake files don't try to deploy the built libraries to the game mod directory (people likely build in a separate environment, not where they have the game installed).
|
Weird you saw the mouse issue too. I made an issue about that earlier, but thought it was my fault because it fixed itself later. |
wootguy
added a commit
that referenced
this pull request
Jan 22, 2024
probably caused by a pointer to a deleted weapon stack trace: #0 in ?? () #1 in GetWeaponData at dlls/client.cpp:1301
wootguy
added a commit
that referenced
this pull request
Feb 18, 2024
looks like another case where EHANDLE should have been used. Stack trace: Program terminated with signal SIGSEGV, Segmentation fault. #0 CBasePlayerWeapon::ItemPostFrame (this=0xa50b7f0) at /home/hlds/sven/valve/addons/SevenKewp/dlls/weapon/CBasePlayerWeapon.cpp:96 96 if (!(m_pPlayer->pev->button & IN_ATTACK)) #0 CBasePlayerWeapon::ItemPostFrame (this=0xa50b7f0) at /home/hlds/sven/valve/addons/SevenKewp/dlls/weapon/CBasePlayerWeapon.cpp:96 #1 0xf1f1b9ed in CBasePlayer::PostThink (this=<optimized out>, this@entry=<error reading variable: value has been optimized out>) at /home/hlds/sven/valve/addons/SevenKewp/dlls/CBasePlayer.cpp:2594 m_pPlayer was NULL
wootguy
added a commit
that referenced
this pull request
Feb 18, 2024
looks like another case where EHANDLE should have been used. Stack trace: Program terminated with signal SIGSEGV, Segmentation fault. #0 CBasePlayerWeapon::ItemPostFrame (this=0xa50b7f0) at CBasePlayerWeapon.cpp:96 96 if (!(m_pPlayer->pev->button & IN_ATTACK)) #0 CBasePlayerWeapon::ItemPostFrame (this=0xa50b7f0) at CBasePlayerWeapon.cpp:96 #1 0xf1f1b9ed in CBasePlayer::PostThink (this=<optimized out>, this@entry=<error reading variable: value has been optimized out>) at CBasePlayer.cpp:2594 m_pPlayer was NULL
wootguy
added a commit
that referenced
this pull request
Feb 18, 2024
looks like another case where EHANDLE should have been used. Stack trace: Program terminated with signal SIGSEGV, Segmentation fault. #0 CBasePlayerWeapon::ItemPostFrame (this=0xa50b7f0) at CBasePlayerWeapon.cpp:96 96 if (!(m_pPlayer->pev->button & IN_ATTACK)) #0 CBasePlayerWeapon::ItemPostFrame (this=0xa50b7f0) at CBasePlayerWeapon.cpp:96 #1 0xf1f1b9ed in CBasePlayer::PostThink (this=<optimized out>, this@entry=<error reading variable: value has been optimized out>) at CBasePlayer.cpp:2594 m_pPlayer was NULL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made it compile on Linux, tested by building on Ubuntu 18.04.6 Bionic Beaver and running on Ubuntu 21.10 Impish Indri. Because I don't have a Windows MSVC build environment to test whether it still compiles, this likely breaks the Windows build; however if it does, hopefully it takes very little effort to fix for both platforms.
I experienced one big problem with the mod, when I turn left and right with the mouse, the arc I can turn in is limited, so I can't turn a full circle and continuously in one direction. I don't know if this is present on Windows too or only on Linux, and whether my modifications are to blame.
This HLSDK vs. SDL issue might be related:
ValveSoftware/halflife#1377