Fix trigger_once #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated CMake files to support build on Linux - Deleted original Linux makefiles as they are not needed since CMake is introduced - Fixed minor problems in the code which prevented the project from compiling It likely breaks the Windows build, but hopefully it only causes minor problems those are easy to fix in a way that allows the project to compile on both platforms. The Linux CMake files don't try to deploy the built libraries to the game mod directory (people likely build in a separate environment, not where they have the game installed).
- Added SDL2 to the list of linked libraries to client.so Not sure if it helps anything, the library loaded without it successfully, but it doesn't hurt either. - Fixed symlinks to Linux and MacOS builds of SDL2 They were supposed to be symlinks and they are in Valve's repo, but in Solokiller's fork they lost their symlink flag with this commit: twhl-community/halflife-updated@6509102
Apparently, the problem is caused by this issue: ValveSoftware/halflife#1377 Which Solokiller has a fix for: twhl-community/halflife-updated@92ffa23 But seems to be originated from L453rh4wk: ValveSoftware/halflife#1546 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surprisingly, CTriggerOnce (trigger_once) was not part of the server library.
I noticed this when I tried to go through Hazard Course and it didn't let me through the first room. Checking the dev console revealed that it "Can't init trigger_once". :D
Sorry for how these pull requests turned out (containing previous commits which causes conflicts), guess I should merge your master before doing further changes.