Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update eslint #547

Merged
merged 8 commits into from
May 27, 2024
Merged

feat: update eslint #547

merged 8 commits into from
May 27, 2024

Conversation

jiho-kr
Copy link
Contributor

@jiho-kr jiho-kr commented May 26, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Use the latest eslint.

https://eslint.org/docs/latest/use/configure/migration-guide

eslint has been changed to flat config.

i kept the existing rules, and added some rules for code quality.

  • @typescript-eslint/prefer-regexp-exec
  • @typescript-eslint/prefer-optional-chain
  • @typescript-eslint/no-base-to-string
  • @typescript-eslint/no-this-alias
  • @typescript-eslint/no-unnecessary-boolean-literal-compare
  • @typescript-eslint/explicit-module-boundary-types
  • @typescript-eslint/consistent-type-imports

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@jiho-kr jiho-kr self-assigned this May 26, 2024
@jiho-kr jiho-kr merged commit 69b4568 into woowabros:main May 27, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant