refactor: dto를 interface로 프로젝션하도록 변경

woowacourse-teams · Mar 13, 2024 · 2627eea · 2627eea
1 parent d1bb360
commit 2627eea
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 13 deletions.
diff --git a/backend/src/main/java/com/digginroom/digginroom/comment/service/CommentService.java b/backend/src/main/java/com/digginroom/digginroom/comment/service/CommentService.java
@@ -77,7 +77,7 @@ public CommentResponse comment(final Long roomId, final Long memberId, final Com
         Comment comment = new Comment(roomId, request.comment(), memberId);
         commentRepository.save(comment);
 
-        return CommentResponse.of(comment, comment.isOwner(memberId), memberNickname.nickName());
+        return CommentResponse.of(comment, comment.isOwner(memberId), memberNickname.getNickname());
     }
 
     public void validateExistRoom(final Long roomId) {
@@ -107,6 +107,6 @@ public CommentResponse update(
         MemberNickname memberNickname = memberRepository.getMemberNickname(memberId);
         Comment comment = commentRepository.getCommentById(commentId);
         comment.updateComment(request.comment(), memberId);
-        return CommentResponse.of(comment, comment.isOwner(memberId), memberNickname.nickName());
+        return CommentResponse.of(comment, comment.isOwner(memberId), memberNickname.getNickname());
     }
 }
diff --git a/backend/src/main/java/com/digginroom/digginroom/repository/MemberRepository.java b/backend/src/main/java/com/digginroom/digginroom/repository/MemberRepository.java
@@ -3,14 +3,8 @@
 import com.digginroom.digginroom.domain.member.Member;
 import com.digginroom.digginroom.exception.MemberException.NotFoundException;
 import com.digginroom.digginroom.repository.dto.MemberNickname;
-import java.util.List;
-import java.util.Map;
 import java.util.Optional;
-import java.util.function.Function;
-import java.util.stream.Collectors;
 import org.springframework.data.jpa.repository.JpaRepository;
-import org.springframework.data.jpa.repository.Query;
-import org.springframework.data.repository.query.Param;
 
 public interface MemberRepository extends JpaRepository<Member, Long> {
 
@@ -26,10 +20,7 @@ default Member getMemberById(final Long id) {
         return findById(id).orElseThrow(NotFoundException::new);
     }
 
-    @Query("SELECT new com.digginroom.digginroom.repository.dto.MemberNickname(id, nickname.nickname) "
-            + "FROM Member "
-            + "WHERE id = :id ")
-    Optional<MemberNickname> findMemberNicknameById(@Param("id") final Long id);
+    Optional<MemberNickname> findMemberNicknameById(final Long id);
 
     default MemberNickname getMemberNickname(final Long id) {
         return findMemberNicknameById(id).orElseThrow(NotFoundException::new);

diff --git a/backend/src/main/java/com/digginroom/digginroom/repository/dto/MemberNickname.java b/backend/src/main/java/com/digginroom/digginroom/repository/dto/MemberNickname.java
@@ -1,4 +1,9 @@
 package com.digginroom.digginroom.repository.dto;
 
-public record MemberNickname(Long memberId, String nickName) {
+import org.springframework.beans.factory.annotation.Value;
+
+public interface MemberNickname {
+
+    @Value("#{target.nickname}")
+    String getNickname();
 }