feat: 이미지 변경할 기능 반환값 변경

#708
woowacourse-teams · Oct 11, 2023 · f9b5bbe · f9b5bbe
1 parent 6a75fbb
commit f9b5bbe
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 7 deletions.
diff --git a/backend/emm-sale/src/documentTest/java/com/emmsale/MemberApiTest.java b/backend/emm-sale/src/documentTest/java/com/emmsale/MemberApiTest.java
@@ -22,6 +22,7 @@
 import com.emmsale.member.application.dto.MemberActivityInitialRequest;
 import com.emmsale.member.application.dto.MemberActivityResponse;
 import com.emmsale.member.application.dto.MemberActivityResponses;
+import com.emmsale.member.application.dto.MemberImageResponse;
 import com.emmsale.member.application.dto.MemberProfileResponse;
 import com.emmsale.member.application.dto.OpenProfileUrlRequest;
 import com.emmsale.member.domain.Member;
@@ -266,14 +267,14 @@ void deleteMemberTest() throws Exception {
   @DisplayName("멤버 프로필을 변경할 수 있다.")
   void updateProfile() throws Exception {
     //given
-    final String imageUrl = "http://imageUrl.png";
+    final MemberImageResponse memberImageResponse = new MemberImageResponse("http://imageUrl.png");
     final Long memberId = 1L;
     final String accessToken = "access_token";
     final MockMultipartHttpServletRequestBuilder builder = createUpdateProfileBuilder(memberId);
 
     when(memberUpdateService.updateMemberProfile
         (any(MultipartFile.class), anyLong(), any(Member.class)))
-        .thenReturn(imageUrl);
+        .thenReturn(memberImageResponse);
 
     //when
     mockMvc.perform(builder

diff --git a/backend/emm-sale/src/main/java/com/emmsale/member/api/MemberApi.java b/backend/emm-sale/src/main/java/com/emmsale/member/api/MemberApi.java
@@ -7,6 +7,7 @@
 import com.emmsale.member.application.dto.MemberActivityAddRequest;
 import com.emmsale.member.application.dto.MemberActivityInitialRequest;
 import com.emmsale.member.application.dto.MemberActivityResponses;
+import com.emmsale.member.application.dto.MemberImageResponse;
 import com.emmsale.member.application.dto.MemberProfileResponse;
 import com.emmsale.member.application.dto.OpenProfileUrlRequest;
 import com.emmsale.member.domain.Member;
@@ -100,12 +101,13 @@ public ResponseEntity<Void> deleteMember(
   }
 
   @PatchMapping("/members/{memberId}/profile")
-  public ResponseEntity<String> updateProfile(
+  public ResponseEntity<MemberImageResponse> updateProfile(
       @PathVariable final Long memberId,
       @RequestPart final MultipartFile image,
       final Member member
   ) {
-    final String imageUrl = memberUpdateService.updateMemberProfile(image, memberId, member);
-    return ResponseEntity.ok(imageUrl);
+    final MemberImageResponse memberImageResponse
+        = memberUpdateService.updateMemberProfile(image, memberId, member);
+    return ResponseEntity.ok(memberImageResponse);
   }
 }
diff --git a/backend/emm-sale/src/main/java/com/emmsale/member/application/MemberUpdateService.java b/backend/emm-sale/src/main/java/com/emmsale/member/application/MemberUpdateService.java
@@ -2,6 +2,8 @@
 
 import com.emmsale.image.application.S3Client;
 import com.emmsale.member.application.dto.DescriptionRequest;
+import com.emmsale.member.application.dto.MemberImageResponse;
+import com.emmsale.member.application.dto.MemberProfileResponse;
 import com.emmsale.member.application.dto.OpenProfileUrlRequest;
 import com.emmsale.member.domain.Member;
 import com.emmsale.member.domain.MemberRepository;
@@ -48,7 +50,7 @@ public void deleteMember(final Member member, final Long memberId) {
     memberRepository.deleteById(memberId);
   }
 
-  public String updateMemberProfile(
+  public MemberImageResponse updateMemberProfile(
       final MultipartFile image,
       final Long memberId,
       final Member member
@@ -66,6 +68,6 @@ public String updateMemberProfile(
     final String imageUrl = s3Client.convertImageUrl(imageName);
     member.updateProfile(imageUrl);
 
-    return imageUrl;
+    return new MemberImageResponse(imageUrl);
   }
 }