-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#100 오픈채팅 프로필 url 등록 기능 구현 #110
The head ref may contain hidden characters: "Feature/#100-\uC624\uD508\uCC44\uD305_\uD504\uB85C\uD544_URL_\uB4F1\uB85D_\uAE30\uB2A5_\uAD6C\uD604"
Changes from all commits
9691064
71a079c
b1a9c00
7de0dda
2148652
7834ee3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
package com.emmsale.member.application; | ||
|
||
import com.emmsale.member.application.dto.OpenProfileUrlRequest; | ||
import com.emmsale.member.domain.Member; | ||
import com.emmsale.member.domain.MemberRepository; | ||
import javax.transaction.Transactional; | ||
import lombok.RequiredArgsConstructor; | ||
import org.springframework.stereotype.Service; | ||
|
||
@Service | ||
@Transactional | ||
@RequiredArgsConstructor | ||
public class MemberUpdateService { | ||
|
||
private final MemberRepository memberRepository; | ||
|
||
public void updateOpenProfileUrl( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. JPA에서는 변경감지를 통해서 데이터를 수정해주는데 @Transactinoal 이 없으면 변경 감지가 동작 안하는 것으로 알고 있습니다,, 저도 트랜잭션 어노테이션 사용안해서 수정 안됐던 기억이,, |
||
final Member member, | ||
final OpenProfileUrlRequest openProfileUrlRequest | ||
) { | ||
final Member persistMember = memberRepository.findById(member.getId()).get(); | ||
final String openProfileUrl = openProfileUrlRequest.getOpenProfileUrl(); | ||
|
||
persistMember.updateOpenProfileUrl(openProfileUrl); | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
package com.emmsale.member.application.dto; | ||
|
||
import com.fasterxml.jackson.annotation.JsonCreator; | ||
import com.fasterxml.jackson.annotation.JsonProperty; | ||
import javax.validation.constraints.Pattern; | ||
import lombok.Getter; | ||
|
||
@Getter | ||
public class OpenProfileUrlRequest { | ||
|
||
@Pattern(regexp = "(https://open.kakao.com/).*") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 지리구요 |
||
private final String openProfileUrl; | ||
|
||
@JsonCreator | ||
public OpenProfileUrlRequest(@JsonProperty final String openProfileUrl) { | ||
this.openProfileUrl = openProfileUrl; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
혹시 MemberUpdateService라고 이름을 지은 이유가 있을까요?
궁금해서요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
개인적으로 클래스의 역할을 파악하기 쉽다고 느껴서 위와 같이 지었습니다.