Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#100 오픈채팅 프로필 url 등록 기능 구현 #110

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions backend/emm-sale/src/docs/asciidoc/index.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,17 @@ include::{snippets}/initial-register-member/http-request.adoc[]
.HTTP response
include::{snippets}/initial-register-member/http-response.adoc[]

=== `PUT`: 사용자의 Open Profile URL 업데이트

.HTTP request 설명
include::{snippets}/update-open-profile-url/request-fields.adoc[]

.HTTP request
include::{snippets}/update-open-profile-url/http-request.adoc[]

.HTTP response
include::{snippets}/update-open-profile-url/http-response.adoc[]

== Event

=== `GET` : 행사 상세정보 조회
Expand Down
Original file line number Diff line number Diff line change
@@ -1,18 +1,22 @@
package com.emmsale.member.api;

import com.emmsale.member.application.MemberActivityService;
import com.emmsale.member.application.MemberUpdateService;
import com.emmsale.member.application.dto.MemberActivityAddRequest;
import com.emmsale.member.application.dto.MemberActivityDeleteRequest;
import com.emmsale.member.application.dto.MemberActivityInitialRequest;
import com.emmsale.member.application.dto.MemberActivityAddRequest;
import com.emmsale.member.application.dto.MemberActivityResponses;
import com.emmsale.member.application.dto.OpenProfileUrlRequest;
import com.emmsale.member.domain.Member;
import java.util.List;
import javax.validation.Valid;
import lombok.RequiredArgsConstructor;
import org.springframework.http.HttpStatus;
import org.springframework.http.ResponseEntity;
import org.springframework.web.bind.annotation.DeleteMapping;
import org.springframework.web.bind.annotation.GetMapping;
import org.springframework.web.bind.annotation.PostMapping;
import org.springframework.web.bind.annotation.PutMapping;
import org.springframework.web.bind.annotation.RequestBody;
import org.springframework.web.bind.annotation.RestController;

Expand All @@ -21,6 +25,7 @@
public class MemberApi {

private final MemberActivityService memberActivityService;
private final MemberUpdateService memberUpdateService;

@PostMapping("/members")
public ResponseEntity<Void> register(
Expand All @@ -45,11 +50,21 @@ public ResponseEntity<List<MemberActivityResponses>> deleteCareer(
final Member member,
@RequestBody final MemberActivityDeleteRequest memberActivityDeleteRequest
) {
return ResponseEntity.ok(memberActivityService.deleteCareer(member, memberActivityDeleteRequest));
return ResponseEntity.ok(
memberActivityService.deleteCareer(member, memberActivityDeleteRequest));
}

@GetMapping("/members/activities")
public ResponseEntity<List<MemberActivityResponses>> findCareer(final Member member) {
return ResponseEntity.ok(memberActivityService.findCareers(member));
}

@PutMapping("/members/open-profile-url")
public ResponseEntity<Void> updateOpenProfileUrl(
final Member member,
@RequestBody @Valid final OpenProfileUrlRequest openProfileUrlRequest
) {
memberUpdateService.updateOpenProfileUrl(member, openProfileUrlRequest);
return ResponseEntity.noContent().build();
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
package com.emmsale.member.application;

import com.emmsale.member.application.dto.OpenProfileUrlRequest;
import com.emmsale.member.domain.Member;
import com.emmsale.member.domain.MemberRepository;
import javax.transaction.Transactional;
import lombok.RequiredArgsConstructor;
import org.springframework.stereotype.Service;

@Service
@Transactional
@RequiredArgsConstructor
public class MemberUpdateService {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹시 MemberUpdateService라고 이름을 지은 이유가 있을까요?
궁금해서요

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

개인적으로 클래스의 역할을 파악하기 쉽다고 느껴서 위와 같이 지었습니다.


private final MemberRepository memberRepository;

public void updateOpenProfileUrl(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JPA에서는 변경감지를 통해서 데이터를 수정해주는데 @Transactinoal 이 없으면 변경 감지가 동작 안하는 것으로 알고 있습니다,,
혹시 http 테스트를 하고 데이터가 변경되었는지 확인하셨는지 궁금합니다 !!

저도 트랜잭션 어노테이션 사용안해서 수정 안됐던 기억이,,

final Member member,
final OpenProfileUrlRequest openProfileUrlRequest
) {
final Member persistMember = memberRepository.findById(member.getId()).get();
final String openProfileUrl = openProfileUrlRequest.getOpenProfileUrl();

persistMember.updateOpenProfileUrl(openProfileUrl);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
package com.emmsale.member.application.dto;

import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
import javax.validation.constraints.Pattern;
import lombok.Getter;

@Getter
public class OpenProfileUrlRequest {

@Pattern(regexp = "(https://open.kakao.com/).*")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

지리구요

private final String openProfileUrl;

@JsonCreator
public OpenProfileUrlRequest(@JsonProperty final String openProfileUrl) {
this.openProfileUrl = openProfileUrl;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ public void updateName(final String name) {
this.name = name;
}

public void updateOpenProfileUrl(final String openProfileUrl) {
this.openProfileUrl = openProfileUrl;
}

public boolean isNotMe(final Member member) {
if (member.getId().equals(id)) {
return false;
Expand Down
24 changes: 21 additions & 3 deletions backend/emm-sale/src/main/resources/http/member.http
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,39 @@ Content-Type: application/json

{
"name": "우르",
"careerIds": [1, 2]
"careerIds": [
1,
2
]
}

### 사용자 커리어 추가
POST http://localhost:8080/members/careers
Content-Type: application/json

{
"careerIds": [4, 5, 6]
"careerIds": [
4,
5,
6
]
}

### 사용자 커리어 제거
DELETE http://localhost:8080/members/careers
Content-Type: application/json

{
"careerIds": [1, 2]
"careerIds": [
1,
2
]
}

### 사용자의 오픈 프로필 URL 업데이트
PUT http://localhost:8080/members/open-profile-url
Content-Type: application/json

{
"openProfileUrl": "https://open.kakao.com/profile"
}
Loading
Loading