Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hong-sile
approved these changes
Jul 31, 2023
|
|
||
| @Sql("/data-test.sql") |
There was a problem hiding this comment.
ServiceTest에서는 ServiceIntegerationTest를 상속받고 있어서, 굳이 @Sql(data-test.sql)을 명시할 필요는 없을거에요
| receiver); | ||
|
|
||
| //then | ||
| assertThat(notifications).extracting("message", String.class) |
There was a problem hiding this comment.
요기는 Notification::getMessage를 사용했어도 좋았을 것 같아요.
amaran-th
approved these changes
Jul 31, 2023
java-saeng
approved these changes
Aug 1, 2023
|
|
||
| @Sql("/data-test.sql") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
close #141
📝작업 내용
알림 목록 조회 api 구현
스크린샷 (선택)
예상 소요 시간 및 실제 소요 시간
1시간/1시간