Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#163 행사 목록 조회 시 반환 데이터에 필드 추가 #174

Conversation

amaran-th
Copy link
Collaborator

#️⃣연관된 이슈

#163

📝작업 내용

  • 행사 목록 조회 시 반환 데이터에 imageUrl, remainingDays 필드 추가
  • 카테고리 필터링 추가
  • 날짜 필터링을 option으로 변경

예상 소요 시간 및 실제 소요 시간

4시간/4시간

amaran-th added 4 commits August 1, 2023 14:29
- Response DTO에 값 추가
- Entity에 값 추가
- findEvents() 수정

#163
…회_시_반환_데이터에_필드_추가

# Conflicts:
#	backend/emm-sale/src/main/java/com/emmsale/event/domain/Event.java
#	backend/emm-sale/src/main/java/com/emmsale/event/domain/EventType.java
#	backend/emm-sale/src/main/resources/schema.sql
#	backend/emm-sale/src/test/java/com/emmsale/event/api/EventApiTest.java
…023-emmsale into Feature/#163-행사_목록_조회_시_반환_데이터에_필드_추가
@amaran-th amaran-th added Backend 백엔드 관련 이슈 기능 추가 새로운 기능 추가 및 기존 기능 변경 High Priority 리뷰 우선순위가 높은 PR labels Aug 1, 2023
@amaran-th amaran-th added this to the 3차 스프린트 2주차 milestone Aug 1, 2023
@amaran-th amaran-th self-assigned this Aug 1, 2023
Copy link
Collaborator

@java-saeng java-saeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 !!! 크게 수정할 부분이 없어 보입니다!!

@@ -22,11 +22,11 @@ create table event
id bigint auto_increment primary key,
created_at datetime(6),
updated_at datetime(6),
end_date datetime(6) not null,
end_date datetime(6) not null,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정렬이 바뀐 것 같아요 ! 정렬 한 번 부탁드립니다

Copy link
Collaborator

@hyeonjerry hyeonjerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다/

@amaran-th amaran-th merged commit 0d27706 into backend-main Aug 1, 2023
1 check passed
@amaran-th amaran-th deleted the Feature/#163-행사_목록_조회_시_반환_데이터에_필드_추가 branch August 4, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend 백엔드 관련 이슈 High Priority 리뷰 우선순위가 높은 PR 기능 추가 새로운 기능 추가 및 기존 기능 변경
Projects
Status: Archive
Development

Successfully merging this pull request may close these issues.

3 participants