Feature/#182 이미 참여한 이벤트인지 확인하는 기능 추가 #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hong-sile
added
Backend
java-saeng
approved these changes
Aug 2, 2023
| @@ -41,7 +41,7 @@ public ResponseEntity<EventDetailResponse> findEventById(@PathVariable final Lon | |||
| } | |||
|
|
|||
| @PostMapping("/{eventId}/participants") | |||
There was a problem hiding this comment.
아래에는 event-id 로 되어있고, 현재는 eventId가 되어있는데 하나로 통일해보는게 어떨까요?
| @@ -100,4 +100,12 @@ public EventDetailResponse updateEvent(@PathVariable(name = "event-id") final Lo | |||
| public void deleteEvent(@PathVariable(name = "event-id") final Long eventId) { | |||
| eventService.deleteEvent(eventId); | |||
| } | |||
|
|
|||
| @GetMapping("/{event-id}/participants/already-participate") | |||
There was a problem hiding this comment.
앞에랑 중복되는 느낌이 있어서 그냥 already 만 있어도 의미전달이 충분해보이는데 어떻게 생각하시나요?
hyeonjerry
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
예상 소요 시간 및 실제 소요 시간
1시간 / 1시간 15분
close #182