Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 함께해요 게시글 삭제 API 엔드포인트 변경 #293

Conversation

hong-sile
Copy link
Collaborator

#️⃣연관된 이슈

📝작업 내용

  • API 엔드포인트 변경

예상 소요 시간 및 실제 소요 시간

  • 10분 / 10분

close #292

@hong-sile hong-sile added Backend 백엔드 관련 이슈 High Priority 리뷰 우선순위가 높은 PR labels Aug 11, 2023
@hong-sile hong-sile added this to the 4차 스프린트 1주차 milestone Aug 11, 2023
@hong-sile hong-sile self-assigned this Aug 11, 2023
@hong-sile hong-sile changed the title refactor: API 엔드포인트 변경 refactor: 함께해요 게시글 삭제 API 엔드포인트 변경 Aug 11, 2023
Copy link
Collaborator

@hyeonjerry hyeonjerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

소소하게 수정할 점 코멘트 남겨 두었어요.
미리 어프룹 하겠습니다. 수고하셨습니다.

public void deleteRecruitmentPost(final Long eventId, final Long postId, final Member member) {
final RecruitmentPost recruitmentPost = recruitmentPostRepository.findById(postId)
.orElseThrow(() -> new EventException(NOT_FOUND_RECRUITMENT_POST));
recruitmentPost.validateEvent(eventId);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

}

@Test
@DisplayName("참가 모집 게시글이")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

뒷 내용이 빠진 것 같습니다.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다.

Copy link
Collaborator

@amaran-th amaran-th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~! 크게 수정할만한 부분은 보이지 않네요~!


@RequiredArgsConstructor
@Getter
public class RecruitmentPostResponse {

private static final String DATE_TIME_FORMAT = "yyyy-MM-dd HH:mm:ss";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

@hong-sile hong-sile merged commit 8eebd83 into backend-main Aug 11, 2023
1 check passed
@hong-sile hong-sile deleted the Feature/#292-함께_해요_게시글_삭제_엔드포인트_수정 branch August 11, 2023 10:45
Copy link
Collaborator

@java-saeng java-saeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

딱히 수정할 부분이 없어보이네요 고생하셨습니다 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend 백엔드 관련 이슈 High Priority 리뷰 우선순위가 높은 PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants