-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: 함께해요 게시글 삭제 API 엔드포인트 변경 #293
The head ref may contain hidden characters: "Feature/#292-\uD568\uAED8_\uD574\uC694_\uAC8C\uC2DC\uAE00_\uC0AD\uC81C_\uC5D4\uB4DC\uD3EC\uC778\uD2B8_\uC218\uC815"
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
소소하게 수정할 점 코멘트 남겨 두었어요.
미리 어프룹 하겠습니다. 수고하셨습니다.
public void deleteRecruitmentPost(final Long eventId, final Long postId, final Member member) { | ||
final RecruitmentPost recruitmentPost = recruitmentPostRepository.findById(postId) | ||
.orElseThrow(() -> new EventException(NOT_FOUND_RECRUITMENT_POST)); | ||
recruitmentPost.validateEvent(eventId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
} | ||
|
||
@Test | ||
@DisplayName("참가 모집 게시글이") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
뒷 내용이 빠진 것 같습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
감사합니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다~! 크게 수정할만한 부분은 보이지 않네요~!
|
||
@RequiredArgsConstructor | ||
@Getter | ||
public class RecruitmentPostResponse { | ||
|
||
private static final String DATE_TIME_FORMAT = "yyyy-MM-dd HH:mm:ss"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
딱히 수정할 부분이 없어보이네요 고생하셨습니다 !
#️⃣연관된 이슈
📝작업 내용
예상 소요 시간 및 실제 소요 시간
close #292