Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyeonjerry
added
Backend
hyeonjerry
changed the title
hong-sile
approved these changes
Sep 27, 2023
amaran-th
approved these changes
Sep 28, 2023
| @@ -104,6 +109,7 @@ public FeedDetailResponse findFeed(final Member member, final Long id) { | |||
| final Feed feed = feedRepository.findById(id) | |||
| .orElseThrow(() -> new FeedException(FeedExceptionType.NOT_FOUND_FEED)); | |||
| final List<Image> images = imageRepository.findAllByFeedId(feed.getId()); | |||
| images.sort(Comparator.comparing(Image::getOrder)); | |||
There was a problem hiding this comment.
ImageRepository의 findAllByFeedId() 쿼리에 order by구문을 추가해줘도 좋을 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
close #670
📝작업 내용
예전에 피드를 구현할 때 피드 이미지를 order 순으로 정렬하는 로직을 빠뜨려 추가했습니다.
예상 소요 시간 및 실제 소요 시간
2시간 / 2시간