-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#69 내 커리어를 조회하는 api 구현 #70
The head ref may contain hidden characters: "Feature/#69-\uB0B4_\uCEE4\uB9AC\uC5B4\uB97C_\uC870\uD68C\uD558\uB294_API_\uAD6C\uD604"
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다!
@@ -81,5 +81,10 @@ public List<MemberCareerResponse> deleteCareer( | |||
|
|||
return MemberCareerResponse.from(memberCareerRepository.findAllByMember(member)); | |||
} | |||
|
|||
@Transactional(readOnly = true) | |||
public List<MemberCareerResponse> findCareer(final Member member) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리스트로 복수개의 커리어를 반환하니 메서드명도 복수로 짓는건 어떨까요?
나중에 하나의 커리어만 조회하는 기능이 생겼을 때 메서드 명이 겹칠 수도 있을 것 같아요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
반영했습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다!!
흠잡을 데가 없네요~~!
#️⃣연관된 이슈
📝작업 내용
close #69