-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#81 로그인 사용자 프로필 이미지 추가 기능 구현 #87
The head ref may contain hidden characters: "Feature/#81-\uB85C\uADF8\uC778_\uC0AC\uC6A9\uC790_\uD504\uB85C\uD544_\uC774\uBBF8\uC9C0_\uCD94\uAC00_\uAE30\uB2A5_\uAD6C\uD604"
Feature/#81 로그인 사용자 프로필 이미지 추가 기능 구현 #87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
크게 말할 게 없네요. Approve 하겠습니다!!
//then | ||
assertThat(expectResponse) | ||
.usingRecursiveComparison() | ||
.ignoringCollectionOrder() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요건 굳이 필요 없는 친구인것 같아요.
import lombok.Getter; | ||
import lombok.NoArgsConstructor; | ||
|
||
@Entity | ||
@Getter | ||
@AllArgsConstructor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
혹시 필요없는 생성자면 지워주시면 감사하겠습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다~ 홍실이랑 페어 피드백 했습니다~
고생하셨습니다~ |
#️⃣연관된 이슈
📝작업 내용
최초 로그인 사용자 깃허브 프로필 이미지 url 등록 기능 구현
사용자 조회 및 생성 서비스 테스트 추가
예상 소요 시간 및 실제 소요 시간
3시간/2시간