Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#81 로그인 사용자 프로필 이미지 추가 기능 구현 #87

Conversation

hyeonjerry
Copy link
Collaborator

#️⃣연관된 이슈

📝작업 내용

최초 로그인 사용자 깃허브 프로필 이미지 url 등록 기능 구현
사용자 조회 및 생성 서비스 테스트 추가

예상 소요 시간 및 실제 소요 시간

3시간/2시간

@hyeonjerry hyeonjerry added Backend 백엔드 관련 이슈 기능 추가 새로운 기능 추가 및 기존 기능 변경 labels Jul 24, 2023
@hyeonjerry hyeonjerry self-assigned this Jul 24, 2023
Copy link
Collaborator

@hong-sile hong-sile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

크게 말할 게 없네요. Approve 하겠습니다!!

//then
assertThat(expectResponse)
.usingRecursiveComparison()
.ignoringCollectionOrder()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요건 굳이 필요 없는 친구인것 같아요.

import lombok.Getter;
import lombok.NoArgsConstructor;

@Entity
@Getter
@AllArgsConstructor
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹시 필요없는 생성자면 지워주시면 감사하겠습니다.

Copy link
Collaborator

@amaran-th amaran-th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~ 홍실이랑 페어 피드백 했습니다~

@java-saeng
Copy link
Collaborator

고생하셨습니다~

@hyeonjerry hyeonjerry merged commit 805c0e0 into backend-main Jul 25, 2023
1 check passed
@hyeonjerry hyeonjerry deleted the Feature/#81-로그인_사용자_프로필_이미지_추가_기능_구현 branch July 31, 2023 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend 백엔드 관련 이슈 기능 추가 새로운 기능 추가 및 기존 기능 변경
Projects
Status: Archive
Development

Successfully merging this pull request may close these issues.

4 participants