-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BE] S3 를 통한 Image Upload 기능 구현 #418
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junpakPark
requested changes
Sep 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩷
♡ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 대상
Image 를 Upload 하는 API 수정
📄 작업 내용
MultipartFile
를 받을 수 있도록 수정이 이외에 이해가 안되는 부분이 있다면 질문 남겨주시면 감사할 것 같아요!
🙋🏻 주의 사항
이야기 해봐야 할 사항들이 조금 있는 것 같아요! 이야기 해본 다음 제가 계속해서 보완해나가도록 하겠습니다.
DB 에 저장해야 할 내용은 Image URL 이라고 생각하시나요? 아니면 fileName 이름이라고 생각하시나요? ex) imageURL ->
https://.../imageName.png
, image 이름 ->imageName.png
cloud front url + "/" + fileName
이니까 file name 만 따서 S3 에 삭제요청 날리면됩니다.cloud front url
을prefix
에 붙여야 하는데, 기존의 데이터들은https://...
이렇게 저장되어 있어,cloud front url + https://...
로 이미지를 요청하게 되요.기존 데이터를 어떻게 활용할 것일까?
이미지 삭제.. 전에 많이 이야기 나눴지만 막상 S3 와 함께 구현해보려 하니까 쉽지 않아요
아직 Rest Docs 를 해결하지 못했더연 도이 말씀대로 notion 에다가 일단 명세 남겨놓고 해결해나가겠습니다. 똥송해연..
스크린샷
📎 관련 이슈
closed #386
레퍼런스
https://blog.pium.life/aws-s3-apply/