-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FE] Refactor/#593 모아보기와 단일조회페이지 분리 및 리팩토링 #607
Merged
Merged
Changes from 14 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
fa19478
refactor: isNotTabBoxShow에 따라 스와이퍼 버튼 위치 조정
semnil5202 4dd35e4
design: banner TabBox 라인 삭제
semnil5202 16b09a5
refactor: 모아보기 기능 SelectedTopic 페이지에서 분리
semnil5202 036b1b5
refactor: resizeMap 로직 훅으로 분리 및 재사용
semnil5202 66ef511
refactor: 네비게이션 하이라이트 기능 훅으로 분리 및 재사용
semnil5202 8b9f3de
refactor: tag 관련 로직 훅으로 분리 및 재사용
semnil5202 85bd580
refactor: 토스트 ui 변경
semnil5202 bc5fa28
refactor: seetogether 페이지 분리
semnil5202 295569b
fix: 모아보기 페이지에서 모아보기 삭제 시 발생하던 오류 수정
semnil5202 f9c4bb8
refactor: 불필요한 import 제거
semnil5202 5c1553e
refactor: 네비게이션 하이라이트 topics에서 무효화 및 로그인 페이지 오류 수정
semnil5202 183bb11
fix: 회원일때는 url 상태로 토픽 조회 하도록 변경하여 새로고침 오류 수정
semnil5202 9322c58
fix: 모아보기를 모두 비운 후 핀이 남아있는 오류 수정
semnil5202 9062508
fix: 모아보기 상태에서 토픽 이미지 수정이 선택한 토픽으로 되지 않는 오류 수정
semnil5202 8df9e14
chore: swiper 제거 후 npm 배포 버전으로 import
semnil5202 01c6e88
refactor: search 페이지 서스펜스 제거
semnil5202 12c0312
Merge branch 'develop-FE' of https://github.com/woowacourse-teams/202…
semnil5202 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
import { useEffect } from 'react'; | ||
|
||
import useMapStore from '../store/mapInstance'; | ||
|
||
const getAvailableWidth = (sidebarWidth: number = 372) => | ||
window.innerWidth - sidebarWidth; | ||
|
||
const getAvailableHeight = () => window.innerHeight; | ||
|
||
const useResizeMap = () => { | ||
const { mapInstance } = useMapStore((state) => state); | ||
|
||
const resizeMap = () => { | ||
if (!mapInstance) return; | ||
|
||
mapInstance.resize(getAvailableWidth(372), getAvailableHeight()); | ||
}; | ||
|
||
useEffect(() => { | ||
if (window.innerWidth > 1180) resizeMap(); | ||
}, [getAvailableWidth(372)]); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 여기 의존성에 getAvailableWidth가 어떤 의민지 잘 모르겠습니다 😓 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 현재 페이지에서 콘텐츠를 보여줄 수 있는 가로 사이즈를 의미합니다. |
||
|
||
return { resizeMap }; | ||
}; | ||
|
||
export default useResizeMap; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
분리 확인요 👍