[Refactor] - Oauth 로그인 과정 코드 리팩터링 및 테스트 작성 #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results12 files 12 suites 3s ⏱️ Results for commit 8f7b214. ♻️ This comment has been updated with latest results. |
4 tasks
hangillee
approved these changes
Jul 25, 2024
eunjungL
approved these changes
Jul 25, 2024
| Date now = new Date(); | ||
| Date validity = new Date(now.getTime() + validityInMilliseconds); | ||
|
|
||
| return Jwts.builder() | ||
| .setSubject(member.getId().toString()) | ||
| .claim(MEMBER_ID_KEY, member.getId()) | ||
| .setSubject(memberId.toString()) |
There was a problem hiding this comment.
그냥 제안) 사용자 정의 claim 넣어줄거면 subject 굳이 안줘도 될 것 같아용 어차피 "sub": "1" 이런식으로 나올거라 무슨 값이 들어온건지 잘 모르기도 할거고
eunjungL
pushed a commit
that referenced
this pull request
Jul 30, 2024
* refactor: example과 response 추가를 통한 api 명세 구체화 개선 * refactor: JwtTokenProvider에서 도메인 의존 제거 개선 * test: JwtTokenProvider 토큰 생성 테스트 작성 * refactor: dto 패키지 계층 및 이너 클래스 구조 분리 * test: 테스트 클래스 단위 DisplayName 설정 * refactor: Member All Argument 생성자 접근 제어 수준 완화 개선 * test: LoginService Mock Test 작성 * test: LoginController 클래스 슬라이스 테스트 작성 * fix: api 명세 수정 * style: 공백 컨벤션에 맞게 수정 개선
hangillee
pushed a commit
to hangillee/2024-touroot
that referenced
this pull request
Aug 20, 2024
* refactor: example과 response 추가를 통한 api 명세 구체화 개선 * refactor: JwtTokenProvider에서 도메인 의존 제거 개선 * test: JwtTokenProvider 토큰 생성 테스트 작성 * refactor: dto 패키지 계층 및 이너 클래스 구조 분리 * test: 테스트 클래스 단위 DisplayName 설정 * refactor: Member All Argument 생성자 접근 제어 수준 완화 개선 * test: LoginService Mock Test 작성 * test: LoginController 클래스 슬라이스 테스트 작성 * fix: api 명세 수정 * style: 공백 컨벤션에 맞게 수정 개선
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 작업 내용
🙈 참고 사항