Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] - Test fixture를 Enum으로 리팩토링 #129

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

hangillee
Copy link

✅ 작업 내용

  • Test fixture를 각 도메인 별로 분리
  • Fixture를 Enum class로 관리하도록 리팩토링

🙈 참고 사항

  • 이제 test fixture를 enum으로 관리하기 시작해서 원하는 편의 메소드를 추가할 수 있습니다.

@hangillee hangillee added the BE label Jul 25, 2024
@hangillee hangillee added this to the sprint 2 milestone Jul 25, 2024
@hangillee hangillee self-assigned this Jul 25, 2024
Copy link

github-actions bot commented Jul 25, 2024

Test Results

12 files  12 suites   3s ⏱️
33 tests 33 ✅ 0 💤 0 ❌
34 runs  34 ✅ 0 💤 0 ❌

Results for commit 4cd4c02.

♻️ This comment has been updated with latest results.

Copy link

@eunjungL eunjungL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

픽스처가 훨씬 깔끔해졌네요 굿굿굿
고생많았슴다 리건쓰~ 👍 👍

return new TraveloguePositionRequest("34.54343", "126.66977");
}

public static List<TraveloguePhotoRequest> getTraveloguePhotoRequests() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 덕분에 코드가 훨씬 깔쌈해지겠는데요 👍 👍 👍

Copy link

@slimsha2dy slimsha2dy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enum을 Fixture로 도입하니 확실히 깔끔해졌다고 느껴지네요.
LGTM! 수고하셨습니다.

@hangillee hangillee merged commit 6bd0dcb into develop/be Jul 25, 2024
3 checks passed
@hangillee hangillee deleted the feature/be/#128 branch July 25, 2024 06:57
eunjungL pushed a commit that referenced this pull request Jul 30, 2024
* refactor: Test fixture를 도메인 별로 분리하고 enum화

* chore: 사용하지 않는 import 구문 제거
hangillee added a commit to hangillee/2024-touroot that referenced this pull request Aug 20, 2024
* refactor: Test fixture를 도메인 별로 분리하고 enum화

* chore: 사용하지 않는 import 구문 제거
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants