-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] - Test fixture를 Enum으로 리팩토링 #129
Conversation
Test Results12 files 12 suites 3s ⏱️ Results for commit 4cd4c02. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
픽스처가 훨씬 깔끔해졌네요 굿굿굿
고생많았슴다 리건쓰~ 👍 👍
return new TraveloguePositionRequest("34.54343", "126.66977"); | ||
} | ||
|
||
public static List<TraveloguePhotoRequest> getTraveloguePhotoRequests() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 덕분에 코드가 훨씬 깔쌈해지겠는데요 👍 👍 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enum을 Fixture로 도입하니 확실히 깔끔해졌다고 느껴지네요.
LGTM! 수고하셨습니다.
* refactor: Test fixture를 도메인 별로 분리하고 enum화 * chore: 사용하지 않는 import 구문 제거
* refactor: Test fixture를 도메인 별로 분리하고 enum화 * chore: 사용하지 않는 import 구문 제거
✅ 작업 내용
🙈 참고 사항
enum
으로 관리하기 시작해서 원하는 편의 메소드를 추가할 수 있습니다.