[Feature] - 로그인 한 사용자만 여행기를 작성할 수 있도록 리팩토링 #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Test Results53 tests 52 ✅ 4s ⏱️ Results for commit 5754dc6. ♻️ This comment has been updated with latest results. |
eunjungL
requested changes
Aug 1, 2024
| String memberId = Objects.requireNonNull(request).getAttribute("memberId").toString(); | ||
|
|
||
| if (memberId == null) { | ||
| throw new BadRequestException("로그인이 필요합니다."); |
There was a problem hiding this comment.
로그인 필요할 땐 UnauthorizedException이 좋을 것 같슴다!
There was a problem hiding this comment.
예외에 대해서 고민을 많이했는데 UnauthorizedException이 좋을 것 같습니다!
| public ResponseEntity<TravelogueResponse> createTravelogue(@Valid @RequestBody TravelogueRequest request) { | ||
| TravelogueResponse response = travelogueFacadeService.createTravelogue(request); | ||
| public ResponseEntity<TravelogueResponse> createTravelogue( | ||
| @NotNull MemberAuth member, |
There was a problem hiding this comment.
질문) MethodArgumentResolver에서 null 검증하고 있는데 여기서 또 validation 붙인 이유가 있나요?.?
There was a problem hiding this comment.
혹시나 해서 붙여뒀습니다.. 방지턱이 많으면 사고 날 일이 없다고 생각해서 😄
Libienz
approved these changes
Aug 1, 2024
Comment on lines
53
to
54
| public ResponseEntity<TravelogueResponse> createTravelogue( | ||
| @NotNull MemberAuth member, |
There was a problem hiding this comment.
@NotNull validation은 @Valid가 있을 때 의미 있다고 알고 있어요!
@NotNull만 사용되고 있어 리뷰 남깁니다.
hangillee
added a commit
to hangillee/2024-touroot
that referenced
this pull request
Aug 20, 2024
* refactor: 패키지 구조 변경 * refactor: 인증된 사용자만 여행기를 작성할 수 있도록 리팩토링 * feat: 사용자 서비스 구현 * refactor: 여행기 관련 테스트에 사용자(작성자) 정보를 추가 * refactor: 로그인 되어 있지 않을 경우 발생하는 예외 타입 변경 * test: 로그인 되어 있지 않을 경우 발생하는 예외 테스트 작성 * chore: 불필요한 어노테이션 제거 * chore: MemberAuth validation 추가 * fix: 변경된 패키지에 맞게 import 구문 수정 * refactor: Project group 수정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 작업 내용