[Feature] - 여행 계획 도메인쪽 인가 적용 #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results52 tests 51 ✅ 4s ⏱️ Results for commit c64ce61. ♻️ This comment has been updated with latest results. |
Libienz
approved these changes
Aug 1, 2024
Comment on lines
+23
to
-29
| oauth: | ||
| kakao: | ||
| redirect-uri: http://localhost:8080/api/v1/login/oauth/kakao | ||
| spring: | ||
| config: | ||
| activate: | ||
| on-profile: local | ||
| oauth: | ||
| kakao: | ||
| redirect-uri: http://localhost:8080/api/v1/login/oauth/kakao |
Comment on lines
34
to
46
| @Operation(summary = "여행 계획 생성") | ||
| @ApiResponses(value = { | ||
| @ApiResponse( | ||
| responseCode = "400", | ||
| description = "Body에 유효하지 않은 값이 존재하거나 지난 날짜에 대한 계획을 생성할 때", | ||
| content = @Content(schema = @Schema(implementation = ExceptionResponse.class)) | ||
| ), | ||
| @ApiResponse( | ||
| responseCode = "401", | ||
| description = "로그인하지 않은 사용자가 생성을 시도할 때", | ||
| content = @Content(schema = @Schema(implementation = ExceptionResponse.class)) | ||
| ) | ||
| }) |
There was a problem hiding this comment.
정상 처리 @ApiResponse가 없네요!
저희 컨벤션으로 지정된 것으로 아는데 확인해보시고 추가해주시길 바랍니다!
There was a problem hiding this comment.
정상처리가 @ApiResponse로 바뀌면 없어지네요.. 확인 후 처리 완료했습니다 👍
Comment on lines
56
to
68
| @Operation(summary = "여행 계획 상세 조회") | ||
| @ApiResponses(value = { | ||
| @ApiResponse( | ||
| responseCode = "400", | ||
| description = "존재하지 않은 여행 계획을 조회할 때", | ||
| content = @Content(schema = @Schema(implementation = ExceptionResponse.class)) | ||
| ), | ||
| @ApiResponse( | ||
| responseCode = "403", | ||
| description = "작성자가 아닌 사용자가 조회를 시도할 때", | ||
| content = @Content(schema = @Schema(implementation = ExceptionResponse.class)) | ||
| ) | ||
| }) |
Comment on lines
41
to
54
| } | ||
|
|
||
| public void validateStartDate() { | ||
| if (startDate.isBefore(LocalDate.now())) { | ||
| throw new BadRequestException("지난 날짜에 대한 계획은 작성할 수 없습니다."); | ||
| } | ||
| } | ||
|
|
||
| public void validateAuthor(Member member) { | ||
| if (!member.equals(author)) { | ||
| throw new ForbiddenException("여행 계획은 작성자만 조회할 수 있습니다."); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
저번에 클로버랑 얘기했었는데 역시 validate보다는 서비스코드가 도메인에 물어보도록 하는 것이 어떨까요?
다른 validate 메서드들이 생겨서 의도가 희석될 수 있을 것 같아요
There was a problem hiding this comment.
동의합니다. Member 스스로 검증하는 것도 방법이 될 수 있을 것 같아요!
hangillee
approved these changes
Aug 1, 2024
eunjungL
commented
Aug 1, 2024
Comment on lines
34
to
46
| @Operation(summary = "여행 계획 생성") | ||
| @ApiResponses(value = { | ||
| @ApiResponse( | ||
| responseCode = "400", | ||
| description = "Body에 유효하지 않은 값이 존재하거나 지난 날짜에 대한 계획을 생성할 때", | ||
| content = @Content(schema = @Schema(implementation = ExceptionResponse.class)) | ||
| ), | ||
| @ApiResponse( | ||
| responseCode = "401", | ||
| description = "로그인하지 않은 사용자가 생성을 시도할 때", | ||
| content = @Content(schema = @Schema(implementation = ExceptionResponse.class)) | ||
| ) | ||
| }) |
There was a problem hiding this comment.
정상처리가 @ApiResponse로 바뀌면 없어지네요.. 확인 후 처리 완료했습니다 👍
Comment on lines
41
to
54
| } | ||
|
|
||
| public void validateStartDate() { | ||
| if (startDate.isBefore(LocalDate.now())) { | ||
| throw new BadRequestException("지난 날짜에 대한 계획은 작성할 수 없습니다."); | ||
| } | ||
| } | ||
|
|
||
| public void validateAuthor(Member member) { | ||
| if (!member.equals(author)) { | ||
| throw new ForbiddenException("여행 계획은 작성자만 조회할 수 있습니다."); | ||
| } | ||
| } | ||
| } |
hangillee
pushed a commit
to hangillee/2024-touroot
that referenced
this pull request
Aug 20, 2024
* fix: package명 kr로 변경 * feat: TravelPlan에 Member 추가 * fix: application.yml dev profile 들여쓰기 오류 수정 * feat: 여행 계획 조회 시 인가 추가 * test: 여행 계획 작성자 인가 테스트 추가 * feat: TravelPlanController에 정상 요청 Swagger 응답 추가 * refactor: TravelPlanService가 검증에 대한 예외를 던지도록 수정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 작업 내용