[Feature] - 여행 계획 공유 기능 구현 #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 22 files 22 suites 4s ⏱️ Results for commit 429adef. ♻️ This comment has been updated with latest results. |
eunjungL
approved these changes
Aug 4, 2024
| @@ -3,7 +3,7 @@ | |||
| import io.swagger.v3.oas.annotations.media.Schema; | |||
|
|
|||
| public record TravelPlanCreateResponse( | |||
| @Schema(description = "생성된 여행 계획 id") | |||
| @Schema(description = "생성된 여행 계획 id", example = "1") | |||
| @@ -95,6 +95,13 @@ public TravelPlanResponse readTravelPlan(Long planId, MemberAuth memberAuth) { | |||
| return TravelPlanResponse.of(travelPlan, getTravelPlanDayResponses(travelPlan)); | |||
| } | |||
|
|
|||
| @Transactional(readOnly = true) | |||
헉 .. 적용되지 않은 기능이 있었네요. |
3 tasks
hangillee
added a commit
to hangillee/2024-touroot
that referenced
this pull request
Aug 20, 2024
* refactor: TravelPlan 공유를 위한 URL 생성에 사용되는 Key(UUID) 필드 추가 * refactor: TravelPlan 생성 과정과 응답 DTO에 UUID 필드 추가 * refactor: TravelPlan UUID 필드 추가에 따른 테스트 코드 수정 * feat: 공유된 여행 계획 조회 기능 구현 * feat: Swagger DTO 필드 example 작성 * fix: 공유된 여행 계획 조회 엔드포인트 수정 * test: 여행 계획 공유 테스트 작성 * refactor: 여행 계획 공유 키 생성 로직 DTO에서 서비스로 이동 개선 * feat: 로그인 되지 않은 유저도 공유된 여행 계획을 조회할 수 있도록 기능 추가 --------- Co-authored-by: hangillee <skfcb10@naver.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 작업 내용
📸 스크린샷
🙈 참고 사항