[Feature] - 태그 생성 및 조회 API 작성 #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 27 files 27 suites 5s ⏱️ Results for commit c690b91. ♻️ This comment has been updated with latest results. |
3 tasks
hangillee
approved these changes
Aug 7, 2024
nak-honest
approved these changes
Aug 7, 2024
| @Transactional | ||
| public TagResponse createTag(TagCreateRequest tagCreateRequest) { | ||
| validateDuplicated(tagCreateRequest); | ||
| Tag savedTage = tagRepository.save(tagCreateRequest.toTag()); |
Comment on lines
+36
to
+42
| @Cacheable(cacheNames = "tag") | ||
| @Transactional(readOnly = true) | ||
| public List<TagResponse> readTags() { | ||
| return tagRepository.findAll().stream() | ||
| .map(TagResponse::from) | ||
| .toList(); | ||
| } |
Comment on lines
19
to
20
| @Column(nullable = false) | ||
| private String tag; |
There was a problem hiding this comment.
어플리케이션 레벨에서 확인하고 있지만,
unique 제약 조건 달아도 좋을 것 같슴다.
slimsha2dy
requested changes
Aug 7, 2024
| ), | ||
| @ApiResponse( | ||
| responseCode = "400", | ||
| description = "Body에 유효하지 않은 값이 존재하지 않거나 중복된 태그가 존재할 때", |
eunjungL
added a commit
that referenced
this pull request
Aug 7, 2024
eunjungL
commented
Aug 7, 2024
| ), | ||
| @ApiResponse( | ||
| responseCode = "400", | ||
| description = "Body에 유효하지 않은 값이 존재하지 않거나 중복된 태그가 존재할 때", |
Comment on lines
19
to
20
| @Column(nullable = false) | ||
| private String tag; |
| @Transactional | ||
| public TagResponse createTag(TagCreateRequest tagCreateRequest) { | ||
| validateDuplicated(tagCreateRequest); | ||
| Tag savedTage = tagRepository.save(tagCreateRequest.toTag()); |
slimsha2dy
approved these changes
Aug 7, 2024
hangillee
pushed a commit
to hangillee/2024-touroot
that referenced
this pull request
Aug 20, 2024
* feat: Tag Entity 추가 * feat: 태그 생성 구현 * docs: 태그 생성 Swagger 작성 * feat: 태그 조회 API * fix: 태그 컨트롤러 url 수정 * feat: 태그 조회 API 캐싱 추가 * docs: 태그 생성 ApiResponse Operation description 수정 * feat: Tag Entity tag에 unqiue 제약 조건 * fix: createTag savedTag 오타 수정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 작업 내용