[Feature] - 여행 계획, 여행기 하위 도메인 조회 명세 변경 #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 27 files 27 suites 6s ⏱️ Results for commit 348d5c4. ♻️ This comment has been updated with latest results. |
hangillee
approved these changes
Aug 7, 2024
slimsha2dy
approved these changes
Aug 7, 2024
| @@ -6,12 +6,14 @@ | |||
|
|
|||
| @Builder | |||
| public record TravelPlanPositionResponse( | |||
| @Schema(description = "여행 게획 장소 상세 Id", example = "1") Long id, | |||
nak-honest
approved these changes
Aug 7, 2024
Comment on lines
-86
to
+87
| public void validateStartDate() { | ||
| if (startDate.isBefore(LocalDate.now())) { | ||
| throw new BadRequestException("지난 날짜에 대한 계획은 작성할 수 없습니다."); | ||
| } | ||
| } | ||
|
|
||
| public boolean isValidStartDate() { | ||
| return startDate.isAfter(LocalDate.now()); | ||
| public boolean isStartDateBefore(LocalDate date) { | ||
| return startDate.isBefore(date); |
There was a problem hiding this comment.
제어할 수 없는 영역을 도메인 외부로 빼신 부분 정말 좋네요!!
2 tasks
hangillee
pushed a commit
to hangillee/2024-touroot
that referenced
this pull request
Aug 20, 2024
* feat: 여행기 하위 도메인 조회 시 Id 속성 추가하도록 수정 * feat: 여행 계획 하위 도메인 조회 시 Id 속성 추가하도록 수정 * fix: 오늘 날짜의 여행을 계획하지 못하는 오류 해결 * feat: 여행기 조회시 작성일자 속성 추가 반환 * feat: 여행기 조회 시 작성자를 확인할 수 있도록 응답 필드 추가 * fix: api 명세 오타 수정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 작업 내용
🙈 참고 사항