Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] - 삭제 API CORS 문제 해결 #248

Merged
merged 1 commit into from
Aug 7, 2024
Merged

[Fix] - 삭제 API CORS 문제 해결 #248

merged 1 commit into from
Aug 7, 2024

Conversation

slimsha2dy
Copy link

✅ 작업 내용

  • cors config에 allowedMethods 추가

@slimsha2dy slimsha2dy added the BE label Aug 7, 2024
@slimsha2dy slimsha2dy added this to the sprint 3 milestone Aug 7, 2024
@slimsha2dy slimsha2dy linked an issue Aug 7, 2024 that may be closed by this pull request
[Fix] - 삭제 API CORS 문제 해결 #239
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

Test Results

 25 files   25 suites   5s ⏱️
184 tests 184 ✅ 0 💤 0 ❌
193 runs  193 ✅ 0 💤 0 ❌

Results for commit 066f05a.

nak-honest
nak-honest approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@nak-honest nak-honest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 지대로 박고 인사 오지게 박습니다 형님.

eunjungL
eunjungL approved these changes Aug 7, 2024
View reviewed changes
Copy link

@eunjungL eunjungL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOOD! 수고하셨습니당

@slimsha2dy slimsha2dy merged commit 79fa055 into develop/be Aug 7, 2024
3 checks passed
@slimsha2dy slimsha2dy deleted the feature/be/#239 branch August 7, 2024 05:46
hangillee
hangillee reviewed Aug 7, 2024
View reviewed changes
Copy link

@hangillee hangillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hangillee hangillee hangillee left review comments

@nak-honest nak-honest nak-honest approved these changes

@eunjungL eunjungL eunjungL approved these changes

Assignees

@slimsha2dy slimsha2dy

Labels
BE
Projects
None yet
Milestone
sprint 3
Development

Successfully merging this pull request may close these issues.

[Fix] - 삭제 API CORS 문제 해결
4 participants
@slimsha2dy @hangillee @eunjungL @nak-honest