[Feature] - 예외 로깅 시 InternalServerError 는 스택 트레이스도 같이 로깅하도록 변경 #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nak-honest
changed the title
1 task
Test Results 27 files 27 suites 5s ⏱️ Results for commit 6e68ad7. ♻️ This comment has been updated with latest results. |
hangillee
approved these changes
Aug 8, 2024
eunjungL
requested changes
Aug 8, 2024
| public ResponseEntity<ExceptionResponse> handleException(Exception exception) { | ||
| log.error("EXCEPTION :: stackTrace = {}", exception.getStackTrace()); | ||
|
|
||
| ExceptionResponse data = new ExceptionResponse(exception.getMessage()); |
There was a problem hiding this comment.
예상치 못한 예외의 메시지를 클라이언트에게 노출시키는 로직인것 같아요~ 한 번 감싸면 좋을 것 같네용
There was a problem hiding this comment.
와우 순간 놓쳤네요 바로 수정 들어가~~~
| @@ -17,7 +17,7 @@ public record MemberRequest( | |||
| @Schema(description = "사용자 닉네임", example = "뚜리") | |||
| @NotBlank(message = "닉네임은 비어있을 수 없습니다.") | |||
| String nickname, | |||
| @Schema(description = "사용자 프로필 사진 URL", example = "S3 이미지 URL") | |||
| @Schema(description = "사용자 프로필 사진 URL", example = "https://dev.touroot.kr/profile-image-ex.png") | |||
hangillee
pushed a commit
to hangillee/2024-touroot
that referenced
this pull request
Aug 20, 2024
…course-teams#264) * feat: 예외 처리 시 InternalServerError 는 stackTrack를 로깅하는 기능 구현 * feat: Swagger 에서 사용자의 프로필 이미지 url example을 실제 url로 변경 * feat: 서버에서 발생한 에러 메시지를 사용자에게 숨기도록 구현
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 작업 내용
🙈 참고 사항