[Feature] - 여행 계획 수정 기능 구현 #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Test Results 31 files 31 suites 9s ⏱️ Results for commit 8474750. ♻️ This comment has been updated with latest results. |
eunjungL
approved these changes
Aug 19, 2024
| String content, | ||
| @Schema(description = "TODO의 체크 여부", example = "true") | ||
| @NotNull(message = "TODO의 체크 여부는 비어 있을 수 없습니다.") | ||
| Boolean isChecked | ||
| ) { | ||
|
|
||
| public TravelPlaceTodo toUncheckedPlaceTodo(TravelPlanPlace travelPlanPlace, Integer order) { |
There was a problem hiding this comment.
이젠 isChecked인 PlaceTodo가 생길 수 있으니 메서드명이 바뀌는게 좋겠네요 ^_^
There was a problem hiding this comment.
어이쿠 빼먹었네요..
바로 수정 완료했습니다..! 🙇
Libienz
approved these changes
Aug 19, 2024
Comment on lines
+86
to
+90
| public void update(String title, LocalDate startDate) { | ||
| this.title = title; | ||
| this.startDate = startDate; | ||
| } | ||
|
|
There was a problem hiding this comment.
우선은 이미 작성된 검증들이 호출되어야 하는 시점이라고 생각합니다..!
검증을 우아하게 하는 방법은.. 고민해보아야겠네요 🤔
There was a problem hiding this comment.
아까 얘기했던 것처럼 리건형 코드랑 같이 별도의 이슈에서 처리하는 것으로 하겠습니다!
hangillee
pushed a commit
to hangillee/2024-touroot
that referenced
this pull request
Aug 20, 2024
* feat: Todo 요청 객체가 체크 여부를 받도록 수정 * feat: 여행 계획 수정 서비스 구현 * feat: 여행 계획 수정 컨트롤러 구현 * style: 요청 객체 네이밍에서 create 제거 * style: 메서드명 수정 * fix: 잘못 입력된 문자 삭제
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 작업 내용
🙈 참고 사항